Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node installation to automatically install the correct versions. #968

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update node installation to automatically install the correct versions. #968

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7f8acd
Update node installation to automatically install the correct versions.
david-pfx Apr 24, 2023
381557f
Fix changes to DEVELOPMENT.md
david-pfx Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ bin/

*.swp
src - Kopie
/node_modules
3 changes: 2 additions & 1 deletion DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ The structure of PuzzleScript is the following:
`./compile.js` uses [node](https://nodejs.org). So first off you have to install that. Then you need to install the packages that it uses:

```
npm i web-resource-inliner ncp rimraf compress-images gifsicle@5.3.0 glob concat ycssmin terser html-minifier-terser gzipper
node install
david-pfx marked this conversation as resolved.
Show resolved Hide resolved
```

The specific packages and versions are now in `package.json`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, but this could be understood as "After running the command, the specific packages and versions are now in package.json.". Might be better to say "This will install the necessary packages as listed in package.json."

Then you should be able to compile the site (outputted to the `./bin/` directory) with

```
Expand Down
2 changes: 1 addition & 1 deletion compile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ creates a highly compressed release build in bin of the contents of src

packages used:

npm i rimraf compress-images web-resource-inliner ncp gifsicle@5.3.0 concat ycssmin terser gzipper html-minifier-terser glob
npm i rimraf compress-images web-resource-inliner ncp gifsicle@5.3.0 concat ycssmin terser gzipper html-minifier-terser glob@8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably remove this line (and maybe replace it with another line saying to use npm install to install the packages listed in package.json.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was my code I would probably just delete it, or replace it with a reference back to DEVELOPMENT.md. Not really my decision, but feel free if so minded.

*/

const fs = require("fs");
Expand Down
Loading