Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggestions mosaiques (NGC-881) #623

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

Clemog
Copy link
Contributor

@Clemog Clemog commented Jun 24, 2024

No description provided.

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nosgestesclimat ✅ Ready (Inspect) Visit Preview Jun 26, 2024 9:04am

Copy link

github-actions bot commented Jun 24, 2024

Report for the pull request #623


🌐 Translation status

UI's texts

Language Nb. missing translations Status
en
Missing 2 UI texts ⬇️
    Rien à l'horizon ! <1></1>La page recherchée n'existe pas.,Rien à l'horizon ! <1></1>La page recherchée n'existe pas. Un bonhomme se demandant où il est,Un bonhomme se demandant où il est
es
Missing 2 UI texts ⬇️
    Rien à l'horizon ! <1></1>La page recherchée n'existe pas.,Rien à l'horizon ! <1></1>La page recherchée n'existe pas. Un bonhomme se demandant où il est,Un bonhomme se demandant où il est

FAQ's questions

Language Nb. missing translations Status
en Ø ✔️
es Ø ✔️

You will find more information about the translation in the dedicated file.

@Clemog Clemog changed the title Fix suggestions mosaiques Fix suggestions mosaiques (NGC-881) Jun 24, 2024
Copy link

@Clemog Clemog force-pushed the fix-suggestions-mosaiques branch from 816c6ff to 1925a0c Compare June 24, 2024 09:42
@Clemog
Copy link
Contributor Author

Clemog commented Jun 25, 2024

En fait, je viens de repérer un bug un peu embêtant sur preprod suite à mes dernieères modifs, le reset des questions mosaiques au clic sur une option ne fonctionne plus

@Clemog
Copy link
Contributor Author

Clemog commented Jun 25, 2024

J'ai réparé mes erreurs ..

@@ -74,14 +77,17 @@ export default function useSetValue({
/**
* @param value - The value to set
* @param options.foldedStep - The dottedName of the foldedStep
* @param options.questionsOfMosaicFromBrother - The dottedNames of the questions of the mosaic from the brother (another child)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or the sister

Copy link
Contributor

@florianpanchout florianpanchout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça m'a l'air clean, mais j'avoue qu'au bout 15000 changement la dedans, j'ai un peu de mal à avoir une vue d'ensemble

@florianpanchout
Copy link
Contributor

Je te fais confiance les yeux semi fermés et je merge pour pouvoir lancer la release

@florianpanchout florianpanchout merged commit 21f2a57 into preprod Jun 26, 2024
6 checks passed
@florianpanchout florianpanchout deleted the fix-suggestions-mosaiques branch June 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants