Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maj page personas #1215

Merged
merged 58 commits into from Jul 19, 2023
Merged

Maj page personas #1215

merged 58 commits into from Jul 19, 2023

Conversation

Clemog
Copy link
Contributor

@Clemog Clemog commented Jul 13, 2023 •
edited

Démo: https://deploy-preview-1215--nosgestesclimat.netlify.app/personas?PR=1968
En lien avec incubateur-ademe/nosgestesclimat#1944

En résumé :

  • Nouveau style de la page (radio boutons pour sélection de la visualisation, cartes de personas plus petites notamment)
  • Ajout de contenus d'explications
  • Ajout de la liste des questions posées pour définir un persona
  • Typage de certaines parties du code (notamment l'ajout d'un type Persona)
  • Typage de certaines parties du code (notamment l'ajout d'un type Persona) -> @EmileRolley je veux bien ton avis quand si tu as le temps de jeter un oeil, j'aurais aimer plus typer certaines fonctions que j'utilise mais un peu lourd dans cette PR déjà assez grosse..)
  • Ajout de nouvelles visualisations:
    • Liste des actions
    • Exhaustivité des règles
    • Description

@netlify
Copy link

netlify bot commented Jul 13, 2023 •
edited

✅ Deploy Preview for nosgestesclimat ready!

Name Link
🔨 Latest commit 518276f
🔍 Latest deploy log https://app.netlify.com/sites/nosgestesclimat/deploys/64b7fa716ea27e000899d237
😎 Deploy Preview https://deploy-preview-1215--nosgestesclimat.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lbranaa lbranaa linked an issue Jul 17, 2023 that may be closed by this pull request
Que faire du persona 2 tonnes qui n'est plus à 2 tonnes ? #767
Closed
Clemog added 25 commits July 18, 2023 15:58
@Clemog
fix: margin for icons in persona cards
ca66427
@Clemog
fix: label is an optionnal props of emoji function
6d391db
@Clemog
fix: props of PersonaGrid
2bff20e
@Clemog
ajout titres choix de visualisation + css
67b9235
@Clemog
add: type persona + fix types
909e435
@Clemog
add: type FinShareButton
224cac6
@Clemog
delete persona warning logic if situation
5251598
@Clemog
fix: naming + type
a650862
@Clemog
fix: type component PersonaGrid
e820487
@Clemog
feat: détails des réponses profil dans la page personas
51703e6
@Clemog
fix: css simulation list
3d8690a
@Clemog
feat: généralise le type Persona
77f8d27
@Clemog
feat: ajout description dans la page personas
5969e0a
@Clemog
extract getFormattedActionValue function
292d113
@Clemog
feat: V0 raw action list
18fdb22
@Clemog
feat: liste actions par catégorie + type
ae9caff
@Clemog
feat: info supplémentaire sur le nombre d'actions à impact
7a34a1d
@Clemog
fix: ordre liste
5beaab5
@Clemog
[WIP] feat: ajout de la liste des questions personas exhaustive
a24b103
@Clemog
feat: ajout de la liste des questions personas exhaustive
9e91077
@Clemog
feat: ajout composant RulesCompletion
31612b1
@Clemog
feat: rules dans les props de RawActionsList
d6ac9f5
@Clemog
feat: ajout explications personas
e656949
@Clemog
fix: affichage mobile
b1a9a54
@Clemog
feat: ajout intro
3ee428e
@github-actions
Copy link

github-actions bot commented Jul 19, 2023 •
edited

Report for the pull request #1215

🌐 Translation status

UI's texts

Language Nb. missing translations Status
en-us
Missing 1 UI texts ⬇️
    Description,Description
 ❌

FAQ's questions

Language Nb. missing translations Status
en-us Ø ✔️

You will find more information about the translation in the dedicated file.

EmileRolley
EmileRolley approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@EmileRolley EmileRolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trop bien ! J'ai push quelques modifs de refactoring, assures toi que je n'ai pas modifié le comportement souhaité 👌

source/reducers/rootReducer.ts Outdated Show resolved Hide resolved
source/selectors/storageSelectors.ts Outdated Show resolved Hide resolved
source/sites/publicodes/ActionVignette.tsx Outdated Show resolved Hide resolved
source/sites/publicodes/ActionVignette.tsx Show resolved Hide resolved
source/sites/publicodes/ActionVignette.tsx Show resolved Hide resolved
EmileRolley and others added 3 commits July 19, 2023 13:16
@EmileRolley
fix: update imports
c96541a
@Clemog @EmileRolley
fix: add type getFormattedActionValue
24bf5c7 
Co-authored-by: Emile Rolley <44124798+EmileRolley@users.noreply.github.com>
@Clemog
fix: types
1e51bae
@Clemog Clemog merged commit 87af452 into master Jul 19, 2023
6 checks passed
@Clemog Clemog deleted the maj-page-personas branch July 19, 2023 15:00
@jeannelf
Copy link

jeannelf commented Oct 3, 2023

intéressant ces détails @Clemog , est-ce que tu te souviens de quel besoin utilisateur ou interne ca émergeait ?

@Clemog
Copy link
Contributor Author

Clemog commented Oct 3, 2023

Besoin exclusivement interne à la fois pour les améliorations du modèle, permettre d'évaluer si les personas sont exhaustifs, correctement paramétrés, permettre de regarder également de plus près les impacts d'un ajout/modif

Et également, côté UI/dev, l'écran permet de voir si les visualisations sont ok pour les personas (et donc pour une majorité de nos utilisateurs), car souvent les graphes et leur affichage dépendent des simulations

@Clemog
Copy link
Contributor Author

Clemog commented Oct 3, 2023

incubateur-ademe/nosgestesclimat#1944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbranaa lbranaa lbranaa left review comments

@EmileRolley EmileRolley EmileRolley approved these changes

@JuliePouliquen JuliePouliquen Awaiting requested review from JuliePouliquen

Assignees

@Clemog Clemog

Labels
None yet
Projects
NGC - (model / website)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Que faire du persona 2 tonnes qui n'est plus à 2 tonnes ?
5 participants
@Clemog @lbranaa @JuliePouliquen @jeannelf @EmileRolley