Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emoji after label #905

Merged
merged 5 commits into from Apr 6, 2023
Merged

emoji after label #905

merged 5 commits into from Apr 6, 2023

Conversation

Clemog
Copy link
Contributor

@Clemog Clemog commented Mar 28, 2023

Fix rapide

Avant :

image

Après :

image

@Clemog Clemog requested a review from laem March 28, 2023 09:41
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for nosgestesclimat ready!

Name Link
🔨 Latest commit 14e320a
🔍 Latest deploy log https://app.netlify.com/sites/nosgestesclimat/deploys/642e91040d988700082ea17e
😎 Deploy Preview https://deploy-preview-905--nosgestesclimat.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 28, 2023

Report for the pull request #905


🌐 Translation status

UI's texts

Language Nb. missing translations Status
en-us Ø ✔️

FAQ's questions

Language Nb. missing translations Status
en-us 14 ⬇️
Check missing rulesges,international,2tonnes,déprime,défaut,services-publics,services-publics-majoritaires,effet-qualité,bio-2,régime,pas-de-voiture,autres-carburants,électricité-dite-verte,impact-numérique

You will find more information about the translation in the dedicated file.

Copy link
Contributor

@laem laem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai ajouté deux commits, dis-moi ce que t'en penses.

@Clemog
Copy link
Contributor Author

Clemog commented Mar 29, 2023

Je suis pas ultra convaincu par les emojis natifs pour ce bouton assez structurant mine de rien et visible partout (ou pas assez justement). Le point info de twemoji est peut etre pas optimal mais on pourrait peut etre dans ce cas en faire un custom ?

@laem
Copy link
Contributor

laem commented Mar 29, 2023

On a /source/images/info.svg, tu en penses quoi ? On peut le colorier en mauve

@Clemog
Copy link
Contributor Author

Clemog commented Mar 29, 2023

Carrément ! On pourrait aussi l'animer au bout de qques secondes

@Clemog
Copy link
Contributor Author

Clemog commented Mar 29, 2023

Après je suis pour une solution simple sur laquelle on a la main, ce svg me semble être un bonne idée

@Clemog Clemog mentioned this pull request Apr 6, 2023
@Clemog Clemog merged commit e731300 into master Apr 6, 2023
6 checks passed
@Clemog Clemog deleted the emojis-radio-label branch April 6, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants