Fix t9n edit #1676
Merged
Fix t9n edit #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for the pull request #1676🚀 Test the model from the website: https://nosgestesclimat.fr?PR=1676 🔧 Model compilation status
🌐 Translation statusRules
Personas
|
|
I merge this PR. Shouldn't be breaking. Next steps :
|
Clemog
commented
Jan 31, 2023
| hasTheSameRefValue = | ||
| targetRef && | ||
| areEqual(targetRef.suggestions, refVal.suggestions) | ||
| hasTheSameRefValue = targetRef && areEqual(targetRef, refVal) |
There was a problem hiding this comment.
@EmileRolley c'était ici le petit bug, je sais pas si c'est lié à d'autres soucis car tu utiliserais cette fonction ailleurs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incubateur-ademe/nosgestesclimat-site#775
This PR fixes hand translations overwrite :
auto, corresponding to deepl translation (I had to run all traductions sorry for you credit card @laem ahah, because we need to know if the translation online (attr with no suffix) is the same as auto translation in order to store hand written translation in case of rewriting)previous_reviewwhich appears if thelockchanged and if the translation is different from auto generated translation. Then a warning informs the user if a rule translation have been improved before changes.Test : locally, change a title anywhere or add a title attribute to a rule (
actionsfor instance with a title different from "actions"), modify the attributetitleintranslated-rules-en-us, you should have a warning when executingyarn check:rulesand then, executeyarn translate:rules, a new line will appears withprevious_reviewattribute.