Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction de la traduction de "plaques vitroceramiques" #1858

Merged
merged 2 commits into from May 2, 2023

Conversation

Vinalti
Copy link
Contributor

@Vinalti Vinalti commented Apr 27, 2023

Explications

Les plaques vitroceramiques étaient traduites littéralement en "plates" hors plates signifie "assiettes" et non plaques de cuissons.

Le terme correcte étant "cooktop" ou "stove" (mais il me semble que ce dernier est plus général (inclus aussi les fours ou poêles à bois/gaz)

Modifications

Le terme "cooking plate" à été remplacé par "cooktop" dans la traduction anglaise

@github-actions
Copy link

github-actions bot commented May 2, 2023

Report for the pull request #1858

🚀 Test the model from the website: https://nosgestesclimat.fr?PR=1858


🔧 Model compilation status

Task Status Message
Supported regions ✔️ Ø
Rules evaluation ✔️ Ø
Successfully compiled and optimized rules:
Expand
  • FR-fr
  • BE-fr
  • CH-fr
  • DE-fr
  • GF-fr
  • GP-fr
  • IT-fr
  • LU-fr
  • MQ-fr
  • PF-fr
  • PL-fr
  • PT-fr
  • RE-fr
  • TN-fr
  • TR-fr
  • UK-fr
  • YT-fr
  • FR-en-us
  • BE-en-us
  • CH-en-us
  • DE-en-us
  • GF-en-us
  • GP-en-us
  • IT-en-us
  • LU-en-us
  • MQ-en-us
  • PF-en-us
  • PL-en-us
  • PT-en-us
  • RE-en-us
  • TN-en-us
  • TR-en-us
  • UK-en-us
  • YT-en-us
✔️ Ø
Personas compilation to JSON for fr ✔️ Ø
Personas compilation to JSON for en-us ✔️ Ø
Documentation compilation to JSON ✔️ Ø

🌐 Translation status

Rules

Language Nb. missing translations Status
en-us
Missing 14 rules ⬇️
  • transport . ferry . vitesse > question
  • transport . ferry . distance aller . orthodromique > question
  • transport . ferry . durée du voyage > question
  • transport . ferry . groupe > question
  • transport . ferry . surface . cabines > question
  • transport . ferry . cabine . nombre > question
  • transport . ferry . cabine > question
  • transport . ferry . surface . loisirs > question
  • transport . ferry . consommation de services > question
  • transport . ferry . surface . sièges > question
  • transport . ferry . voiture > question
  • transport . ferry . surface . garage . bas > question
  • transport . ferry . surface . garage . haut > question
  • transport . ferry . surface . communs > question

Personas

You will find more information about the translation in the dedicated file.


👫 Personas changes

Test personas regression

Persona Total PR (kg CO2e) Total in prod. (kg CO2e) Δ (%)

Test model optimisation

Persona Total PR with optim. (kg CO2e) Total PR without optim. (kg CO2e) Δ (%)

@Clemog
Copy link
Contributor

Clemog commented May 2, 2023

Hello @Vinalti, merci pour la PR (et les autres ! ;) )

J'ai juste repris les attributs du yaml auto qui sont justement là pour éviter de perdre la traduction si on change ces règles de calculs par la suite :) (Si change le titre de 'plaques' pour 'plaques vitro', on veut éviter de retrouver 'plates' que tu viens de corriger)

@Clemog Clemog merged commit 70cd1a6 into incubateur-ademe:master May 2, 2023
11 checks passed
@Vinalti Vinalti deleted the correct-translation-cooktop branch May 2, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants