Ajoute ButtonGroup au design system #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariheck
reviewed
May 6, 2024
| : { | ||
| borderTopLeftRadius: 0, | ||
| borderBottomLeftRadius: 0, | ||
| borderLeft: 0, |
There was a problem hiding this comment.
Ici si aucun activeButtonId n'est renseigné, il n'y a pas de séparation entre les deux boutons
| {...props} | ||
| size={size} | ||
| variant={activeButtonId === props.id ? 'primary' : 'outlined'} | ||
| style={getButtonStyles(index)} |
There was a problem hiding this comment.
Si un des boutons est disabled, ça peut impacter le style de bordure du bouton d'à côté
|
|
||
| type Props = { | ||
| /** Listes de boutons à afficher avec leurs propriétés */ | ||
| buttons: ButtonProps[]; |
There was a problem hiding this comment.
J'aurais plutôt utilisé DefaultButtonProps pour éviter l'utilisation de liens sur les groupes de boutons
mariheck
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.