Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for v8.1.1 #131

Merged
merged 2 commits into from
Aug 11, 2015
Merged

Update CHANGELOG.md for v8.1.1 #131

merged 2 commits into from
Aug 11, 2015

Conversation

adam-thomas
Copy link
Contributor

From #129.

@meshy here you go :)

@@ -38,6 +38,10 @@
* Note that `email_verified == not email_verification_required`.
* A data migration will be necessary.

## v8.1.1

* Bugfix: Don't show "passwords do not match" when the first password is invalid.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should mention that it is a cherry-pick of a later release, otherwise it looks very odd that this is in the history twice.

That said, I don't see this elsewhere in this file... are you sure that this was fixed before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code presumably got changed at some point between 8.x and 12.x as part of larger works. Whether to deliberately fix this bug or not, I don't know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to find the fix...turns out that v8.1.0 is not an ancestor of master.

https://raw.githubusercontent.com/meshy/gifs/master/cersei-eye-roll.gif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually -- I got the bisect the wrong way round.. Oops!

https://raw.githubusercontent.com/meshy/gifs/master/picard-giggle.gif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahahaha :P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for v11)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be the one.

@meshy
Copy link
Contributor

meshy commented Aug 11, 2015

updated

meshy added a commit that referenced this pull request Aug 11, 2015
@meshy meshy merged commit f9db697 into master Aug 11, 2015
@meshy meshy deleted the update-changelog-for-8.1.1 branch August 11, 2015 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants