-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md for v8.1.1 #131
Conversation
@@ -38,6 +38,10 @@ | |||
* Note that `email_verified == not email_verification_required`. | |||
* A data migration will be necessary. | |||
|
|||
## v8.1.1 | |||
|
|||
* Bugfix: Don't show "passwords do not match" when the first password is invalid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should mention that it is a cherry-pick of a later release, otherwise it looks very odd that this is in the history twice.
That said, I don't see this elsewhere in this file... are you sure that this was fixed before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code presumably got changed at some point between 8.x and 12.x as part of larger works. Whether to deliberately fix this bug or not, I don't know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hahahaha :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the change happened here: https://github.com/incuna/django-user-management/commit/fefdf6a3b9044178ebbe269b3a1f2c1ab1b7b170/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(for v11)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be the one.
updated |
From #129.
@meshy here you go :)