Make all fields a tuple in serializers #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2015 12:21
If in a project we define a tuple of core fields and try to concatenate them with the original serializer fields we need to add an exception to `RegistrationSerializer`. Making all fields a tuple allow to subclass them more easily.
|
I also like this, as it stops changes to the fields from accidentally propagating up the tree of subclasses. |
|
Ready for review/merge. Not sure if it was a breaking change but it looks like project sub-classing |
|
@kevinetienne I agree, frustrating as it is, I think this does count as a breaking change. It might be worth expanding on the changelog to briefly explain how to migrate to this version. |
|
Cool thanks, I'll do that |
|
Updated, @Ian-Foote @adam-incuna can you review/merge please? |
|
👍 |
adam-thomas
added a commit
that referenced
this pull request
Aug 24, 2015
Make all fields a tuple in serializers
|
Thanks :) |
| class CustomRegistration(RegistrationSerializer): | ||
| class Meta(RegistrationSerializer.Meta): | ||
| fields = RegistrationSerializer.Meta.fields + ('custom_field',) | ||
| ``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If in a project we define a tuple of core fields and try to concatenate
them with the original serializer fields we need to add an exception to
RegistrationSerializer.Making all fields a tuple allow to subclass them more easily.