Make token expires for AccountVerifyView #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default `signing.loads` has `max_age` sets to `None` which makes the token to validate an account to never expire.
| settings, | ||
| 'VERIFY_ACCOUNT_EXPIRY', | ||
| self.DEFAULT_VERIFY_ACCOUNT_EXPIRY, | ||
| ) |
There was a problem hiding this comment.
try:
max_age = settings.VERIFY_ACCOUNT_EXPIRY
except AttributeError:
max_age = self.DEFAULT_VERIFY_ACCOUNT_EXPIRY
kevinetienne
force-pushed
the
verify-token-age
branch
from
4025bcd
to
6f22616
Compare
|
@Ian-Foote @meshy can you review/merge? |
| Set user as a class attribute or raise an `InvalidExpiredToken`. | ||
| """ | ||
| try: | ||
| email_data = signing.loads(kwargs['token']) | ||
| max_age = settings.VERIFY_ACCOUNT_EXPIRY |
There was a problem hiding this comment.
Might it make more sense to add this to an app config?
There was a problem hiding this comment.
or, failing that, on this view?
There was a problem hiding this comment.
Hmm, maybe. I don't think it matters much.
There was a problem hiding this comment.
I was thinking about the app config, maybe we should wait until we drop support for 1.6
LilyFoote
added a commit
that referenced
this pull request
Sep 2, 2015
Make token expires for AccountVerifyView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
signing.loadshasmax_agesets toNonewhich makes thetoken to validate an account to never expire.