Swap request.DATA for request.data #135
Conversation
|
Wait, I missed a requirements update in |
|
Also tests are sad. Will fix. |
|
@incuna/backend This is now less rushed. Review/merge please? :) |
| @@ -5,7 +5,7 @@ | |||
|
|
|||
|
|
|||
| install_requires = ( | |||
| 'djangorestframework>=3.1.0,<3.2', | |||
| 'djangorestframework>=3.2.0,<3.3', | |||
There was a problem hiding this comment.
Do we need to drop v3.1 support?
There was a problem hiding this comment.
Not that I know of, I just wanted it to use 3.2 for tests/local installs. Do I have to faff around to maintain 3.1 support as well?
There was a problem hiding this comment.
Or will this command fetch the newest possible version of DRF?
There was a problem hiding this comment.
Yeah it does, doesn't it. I'll change it to >3.1.0.
There was a problem hiding this comment.
Only if you've broken compatibility. If 3.1 still works, just change the >=3.2.0,<3.3 to >=3.1.0,<3.3.
We could also include the DRF version in the tox setup for travis. That would double the test runs though...
|
Updated! |
|
Bump? This is a bit urgent. |
Swap request.DATA for request.data
|
Thanks! :) |
@incuna/backend merge please? :)