Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-groups does not respect comments in import block #11

Closed
mcavoyk opened this issue Jul 15, 2020 · 2 comments
Closed

go-groups does not respect comments in import block #11

mcavoyk opened this issue Jul 15, 2020 · 2 comments
Labels
bug Something isn't working
Milestone
go-groups v1.1.0

Comments

@mcavoyk
Copy link

mcavoyk commented Jul 15, 2020 •
edited

go version: 1.14.5
go-groups version: 0.0.1

package main

import (
        // example comment
	"fmt"
)

func main() {
	fmt.Println("Hello world")
}

goimports leaves comment while go-groups removes.
@mcavoyk
Copy link
Author

mcavoyk commented Jul 15, 2020

May be related to #10

@cnmcavoy cnmcavoy added the bug Something isn't working label Jul 15, 2020
@cnmcavoy cnmcavoy added this to the go-groups v1.1.0 milestone Jul 15, 2020
cnmcavoy added a commit that referenced this issue Jul 15, 2020
@cnmcavoy
gh-11: update imports to own content above/beneath them
0d57fe3
cnmcavoy added a commit that referenced this issue Jul 15, 2020
@cnmcavoy
Merge branch 'gh-11' into release
5db15bc
@cnmcavoy
Copy link
Member

Fixed in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
go-groups v1.1.0
Development

No branches or pull requests
2 participants
@mcavoyk @cnmcavoy