Add describeWorkflow method in Client #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zklgame
force-pushed
the
zklgame/add_get_workflow_status_api
branch
from
ffccbdc
to
0d12a67
Compare
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
============================================
+ Coverage 69.71% 69.88% +0.16%
- Complexity 343 345 +2
============================================
Files 57 57
Lines 1453 1461 +8
Branches 134 134
============================================
+ Hits 1013 1021 +8
Misses 368 368
Partials 72 72
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| * @param workflowRunId optional | ||
| * @return the workflow's status | ||
| */ | ||
| public WorkflowStatus getWorkflowStatus( |
There was a problem hiding this comment.
maybe getWorkflowInfo or describeWorkflow (the name is from Cadence/Temporal)
because we can extend it to get more fields, like workflowStartTime
There was a problem hiding this comment.
Should I put the new class WorkflowInfo into the idl or just in the java-sdk?
I created a MR to add it as a general schema in the idl:
https://github.com/indeedeng/iwf-idl/pull/43/files
There was a problem hiding this comment.
Probably in SDK to keep the idl simple for now
longquanzheng
approved these changes
Jul 14, 2023
zklgame
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.