Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpc interface without persistence #219

Merged

Conversation

duoertai
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 71.43%. Comparing base (08a5d25) to head (b258803).
Report is 3 commits behind head on main.

Files Patch % Lines
.../main/java/io/iworkflow/core/RpcMethodMatcher.java 73.01% 10 Missing and 7 partials ⚠️
src/main/java/io/iworkflow/core/Client.java 20.00% 4 Missing ⚠️
src/main/java/io/iworkflow/core/WorkerService.java 66.66% 2 Missing and 2 partials ⚠️
...rc/main/java/io/iworkflow/core/RpcDefinitions.java 33.33% 1 Missing and 1 partial ⚠️
...n/java/io/iworkflow/core/RpcInvocationHandler.java 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #219      +/-   ##
============================================
- Coverage     71.69%   71.43%   -0.26%     
- Complexity      397      416      +19     
============================================
  Files            61       64       +3     
  Lines          1639     1740     +101     
  Branches        149      160      +11     
============================================
+ Hits           1175     1243      +68     
- Misses          387      412      +25     
- Partials         77       85       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 103 to 104
public static final int PARAMETERS_WITH_INPUT = 4;
public static final int PARAMETERS_NO_INPUT = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like these two constants are outdated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, PARAMETERS_NO_INPUT is not used anymore, *WITH_INPUT seems still being used in other classes, I'll clean this up

@duoertai duoertai marked this pull request as ready for review March 2, 2024 15:30
@duoertai duoertai changed the title [WIP] Add rpc interface without persistence Add rpc interface without persistence Mar 2, 2024
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good job!

src/main/java/io/iworkflow/core/WorkerService.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/UnregisteredClient.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/RpcMethodMatcher.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/RpcMethodMatcher.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/RpcMethodMatcher.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/RpcMethodMatcher.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/RpcMethodMatcher.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/RpcMethodMatcher.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/RpcMethodMatcher.java Outdated Show resolved Hide resolved
@duoertai duoertai linked an issue Mar 8, 2024 that may be closed by this pull request
@longquanzheng longquanzheng merged commit dc66ac7 into indeedeng:main Mar 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow RPC definition without persistence
2 participants