New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rpc interface without persistence #219
Add rpc interface without persistence #219
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
============================================
- Coverage 71.69% 71.43% -0.26%
- Complexity 397 416 +19
============================================
Files 61 64 +3
Lines 1639 1740 +101
Branches 149 160 +11
============================================
+ Hits 1175 1243 +68
- Misses 387 412 +25
- Partials 77 85 +8 ☔ View full report in Codecov by Sentry. |
public static final int PARAMETERS_WITH_INPUT = 4; | ||
public static final int PARAMETERS_NO_INPUT = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like these two constants are outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, PARAMETERS_NO_INPUT is not used anymore, *WITH_INPUT seems still being used in other classes, I'll clean this up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good job!
No description provided.