Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup project #1

Merged
merged 5 commits into from
May 23, 2023
Merged

Setup project #1

merged 5 commits into from
May 23, 2023

Conversation

zhxnlai
Copy link
Collaborator

@zhxnlai zhxnlai commented May 23, 2023

No description provided.

Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK need to switch to use https://github.com/indeedeng/iwf-idl/blob/main/iwf-sdk.yaml instead (the other one is a superset of SDK yaml. It's for server to keep compability of older SDK versions).

Also, can you check in the script of generating the API code?

@zhxnlai
Copy link
Collaborator Author

zhxnlai commented May 23, 2023

please take another look

@longquanzheng
Copy link
Contributor

Looks great to me:
If you want to be better:
Maybe add the instruction for how to initialize the submodule and update the iDL:

git submodule update --init --recursive

git submodule update --remote --merge

See example in https://github.com/indeedeng/iwf-java-sdk/#using-intellij

@zhxnlai zhxnlai merged commit c01c641 into main May 23, 2023
2 checks passed
@zhxnlai zhxnlai deleted the setup-project branch May 24, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants