WIP for fixing uploads #1016
Merged
WIP for fixing uploads #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8ab29a6.
|
Post-mortem: it turns out we inadvertently added a non-nullable column while using a prod database to test #893. The new ActiveStorage versions enabled in that PR set and use the column properly, but since we didn't release that PR (see blockers there) we had a non-nullable column on avatar uploads that wasn't being used in prod -- that didn't exist in isolated dev/staging databases. Therefore, uploads succeeded in dev and staging but failed in production. The migration in this PR removes that column to get things back to a consistent state between prod/staging/dev. The column will be added back in #893. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our prod db is out of wack. This PR has a migration to get it back under control.
We probably don't actually have to revert these gem versions after all, but that sounds like a job for Tomorow Andrew.