draft-ietf-secevent-http-push last call feedback #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfissued
approved these changes
Apr 15, 2019
draft-ietf-secevent-http-push.xml
Outdated
| @@ -101,7 +101,7 @@ | |||
| when, and only when, they appear in all capitals, as shown here. | |||
| </t> | |||
|
|
|||
| <t>Throughout this documents all figures may contain spaces and | |||
| <t>Throughout this document all figures may contain spaces and | |||
There was a problem hiding this comment.
Add a comma after "document".
draft-ietf-secevent-http-push.xml
Outdated
| Recipient may accept or reject (i.e., return an <spanx style="verb">access_denied</spanx> | ||
| error response) at its own discretion. | ||
| Recipient may accept or reject (i.e., return an error response such as | ||
| <spanx style="verb">access_denied</spanx>) at its own discretion. |
There was a problem hiding this comment.
Add "a SET" before "at its own discretion". Currently the sentence doesn't say what it is that would be accepted or rejected.
|
Mike, please merge when you get a chance. I cannot merge since I don't have write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editorial changes based on feedback from these threads: