Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting the Tests Running #29

Closed
Emerson opened this issue Jul 22, 2014 · 7 comments
Closed

Getting the Tests Running #29

Emerson opened this issue Jul 22, 2014 · 7 comments

Comments

@Emerson
Copy link

Emerson commented Jul 22, 2014

Howdy,

I'd like to start submitting some pull requests to this repo but can't seem to get the tests running locally. What's the protocol for getting these setup? I have grunt running, but I'm not sure what's supposed to happen next?

Once I have this setup I'm happy to write some docs.

@asaf
Copy link
Contributor

asaf commented Jul 26, 2014

@Emerson I guess we should wait for Broccoli first

@Emerson
Copy link
Author

Emerson commented Jul 26, 2014

Yup, let's close this up and assume the tests will start working on the broccoli branch!

@Emerson Emerson closed this as completed Jul 26, 2014
@asaf
Copy link
Contributor

asaf commented Jul 26, 2014

Agreed!

@asaf asaf reopened this Aug 22, 2014
@asaf
Copy link
Contributor

asaf commented Aug 22, 2014

Reopened as tests still not executed properly.

@Emerson
Copy link
Author

Emerson commented Aug 22, 2014

Hmmm, they were working on my broccoli branch - I'll take a look and let you know if I find anything.

@Emerson
Copy link
Author

Emerson commented Aug 22, 2014

Ah, I see that the Brocfile has been trimmed down.

How did you want to handle the tests? Is that something that belongs in the Brocfile.js? I remember you saying that you'd like to keep the Brocfile very sparse, but I found that getting the tests working required a bunch of extra code.

My Brocfile had the tests working, but was pretty large. Check it out here

@asaf
Copy link
Contributor

asaf commented Aug 23, 2014

Well, i dont see a reason why tests should be built,
There must be a way to run them as is,

Ill work on it later on.

@asaf asaf mentioned this issue Nov 18, 2014
asaf pushed a commit that referenced this issue Nov 18, 2014
@asaf asaf closed this as completed Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants