Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in model now reflect on form: Issue #82 & Issue #23 #92

Closed
wants to merge 3 commits into from

Conversation

xcskier56
Copy link

Changes by @BenjaminHorn and @michetti to allow updates in the model to be reflected in the form. This should close Issue #82 and Issue #23

@joshpfosi
Copy link

@asaf, will this be merged soon? I am debating forking from this branch as this change is make or break.

@koryteg
Copy link

koryteg commented Apr 3, 2015

+1 for this. will this be merged soon?

@xcskier56
Copy link
Author

@joshpfosi Have you created a fork for this feature? I'd be happy to help.

@joshpfosi
Copy link

I actually have not. I don't have time at the moment, but it should be straightforward to take this pull request, right?

@koryteg
Copy link

koryteg commented Apr 20, 2015

@joshpfosi for myself I just set my package.json to get this fork and commit for the time being, until this gets updated. I should probably fork @xcskier56 so I am not depending on his fork.

@joshpfosi
Copy link

Any progress on this? Cans someone list their package.json? How can I pull in http://github.com/perk-health/ember-forms.git into my project? Thanks!

@asaf
Copy link
Contributor

asaf commented May 11, 2015

Merged.

@joshpfosi
Copy link

I still experience this problem even with EmberForms 0.6.0. Looking into this now, but it appears to be the identical problem.

@pedrokiefer
Copy link
Contributor

@joshpfosi I'm not sure if this is not already fixed on this fork: https://github.com/piceaTech/ember-rapid-forms

@joshpfosi
Copy link

@pedrokiefer, I experience an issue when using ember-rapid-forms:

version: 0.1.15
Cannot find module 'handlebars'
Error: Cannot find module 'handlebars'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at /Users/joshpfosi/shearwater/ember/bower_components/ember/ember-template-compiler.js:34:16
    at Object.<anonymous> (/Users/joshpfosi/shearwater/ember/bower_components/ember/ember-template-compiler.js:332:3)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)

Any ideas on this?

@pedrokiefer
Copy link
Contributor

@joshpfosi never saw this error before.

@joshpfosi
Copy link

Hmm. Just created a fresh ember app and experienced the same issue: https://github.com/joshpfosi/ember-rapid-forms-bug

Do you have a working package.json I could check against?

Edit: Confirmed, without ember-rapid-forms the server ran w/o errors

@pedrokiefer
Copy link
Contributor

@joshpfosi I think it's something with the version of your ember-cli, but I might be mistaken.

Confirmed, you are running ember 1.8, try updating to ember-cli 0.2.3 and ember 1.10 or 1.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants