Added support for "node-gyp" build

[TooTallNate]

Hey @indexzero! I've added support for the new gyp build system and node-gyp, since node-waf has been removed in node v0.8. So this simply ensures forward compatibility. Cheers!

[indexzero]

Thanks. @TooTallNate this is an all-or-nothing thing right? i.e. We should merge this into a v0.8 feature branch until v0.8 is out?

[TooTallNate]

The way I set this one up is kinda all-or-nothing, since I deleted the install script and changed the preinstall phase. I could revert that commit and that way you would just have the bindings.gyp file ready, but the waf build would still take precedence for now. Does that sound better?

Otherwise ya, you should probably merge into a v0.8 branch or something.

[indexzero]

@TooTallNate I have no problem merging into a v0.8 branch. That was our approach for the v0.6 migration.

[indexzero]

Thanks again!

[TooTallNate]

Bump?

[kangax]

Any progress on this?

[indexzero]

When 0.8.0 goes live we'll merge this in.

[TooTallNate]

What's the rationale there?

[indexzero]

@TooTallNate Is gyp in node@0.6.x? If I understand it correctly this branch won't work on 0.6.x so the rationale is not breaking the build.

If I'm wrong, please let me know what what I'm missing.

[TooTallNate]

It's actually bound to the npm version:

npm v1.1.x and up come with node-gyp bundled internally (i.e. it doesn't get installed to your PATH, but it does get used when invoking npm install ...). So if the user has at least this version of npm, then node-gyp will be used when installing the module when it sees a binding.gyp file in the repo.

If they don't have a version of npm at least this new, then it will use the old npm behavior, which would be to invoke node-waf automatically when it sees a wscript file in the repo.

So it's possible (and actually ideal) to enable a "dual-build" setup, where there's both a wscript and binding.gyp file in the repo, and no "scripts.preinstall" or "scripts.install" phases in the package.json. Then npm will "just work" (use node-gyp on newer npms, node-waf on older npms) when it comes to compiling the module.

Make sense? I know it's a little confusing...

[indexzero]

Yes it does. Thanks for clarifying. We'll try to get this published sooner then.

[tomas]

Hey guys,

v0.8.1 is out there and I'm getting a nasty error after installing/building the current version (no suitable image found, wrong architecture). Any chances this gets merged soon?

Thanks for the great module, by the way.

[TooTallNate]

@tomas node v0.8.x has the new "detached" option, which supersedes this module. You should use that instead.

[tomas]

Yikes, totally missed it. Thanks for pointing it out @TooTallNate.

I guess it still should be merged though. :)

[indexzero]

@tomas Actually no. I'm not going to merge this because this module is now officially deprecated. You should only be using this on node <= 0.7.10.

I will make the deprecation notice formal later today. @TooTallNate thanks for the work though!

[tomas]

On second thought, it makes total sense, haha.