-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for "node-gyp" build #12
Conversation
Thanks. @TooTallNate this is an all-or-nothing thing right? i.e. We should merge this into a v0.8 feature branch until v0.8 is out? |
The way I set this one up is kinda all-or-nothing, since I deleted the Otherwise ya, you should probably merge into a |
@TooTallNate I have no problem merging into a v0.8 branch. That was our approach for the v0.6 migration. |
Thanks again! |
npm does this for us.
This reverts commit fc69b50.
Bump? |
Any progress on this? |
When 0.8.0 goes live we'll merge this in. |
What's the rationale there? |
@TooTallNate Is gyp in If I'm wrong, please let me know what what I'm missing. |
It's actually bound to the
If they don't have a version of npm at least this new, then it will use the old npm behavior, which would be to invoke So it's possible (and actually ideal) to enable a "dual-build" setup, where there's both a Make sense? I know it's a little confusing... |
Yes it does. Thanks for clarifying. We'll try to get this published sooner then. |
Hey guys, v0.8.1 is out there and I'm getting a nasty error after installing/building the current version (no suitable image found, wrong architecture). Any chances this gets merged soon? Thanks for the great module, by the way. |
@tomas node v0.8.x has the new "detached" option, which supersedes this module. You should use that instead. |
Yikes, totally missed it. Thanks for pointing it out @TooTallNate. I guess it still should be merged though. :) |
@tomas Actually no. I'm not going to merge this because this module is now officially deprecated. You should only be using this on I will make the deprecation notice formal later today. @TooTallNate thanks for the work though! |
On second thought, it makes total sense, haha. |
Hey @indexzero! I've added support for the new gyp build system and
node-gyp
, sincenode-waf
has been removed in nodev0.8
. So this simply ensures forward compatibility. Cheers!