Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Document lowerCase option in .env(options) #241

Closed
wants to merge 1 commit into from
Closed

[doc] Document lowerCase option in .env(options) #241

wants to merge 1 commit into from

Conversation

simonrenoult
Copy link

As stated in #177, the lowerCase option was never mentioned in the documentation.

@simonrenoult
[doc] Document lowerCase option in .env(options)
237b2a9 
- Add missing documentation about the lowerCase option
AdrieanKhisbe
AdrieanKhisbe approved these changes Mar 31, 2017
View reviewed changes
Copy link
Contributor

@AdrieanKhisbe AdrieanKhisbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good
Though would prefer to have nconf.env(); rather than nconf.env({ lowerCase: false }); to emphasize that default is false

@indexzero
Copy link
Owner

@simonrenoult thanks for the docs! Agree with @AdrieanKhisbe about the usage nitpick. Will cherry-pick and make the change.

@mhamann mhamann mentioned this pull request Aug 16, 2017
Merged
@mhamann
Copy link
Collaborator

mhamann commented Aug 16, 2017

Cherry-picked via #268

@mhamann mhamann closed this Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrieanKhisbe AdrieanKhisbe AdrieanKhisbe approved these changes

Assignees
No one assigned
Labels
patch-version yes-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonrenoult @indexzero @mhamann @AdrieanKhisbe