Add support for nested configs via env #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,7 +183,7 @@ Memory.prototype.merge = function (key, value) { | |||
| } | |||
|
|
|||
| return Object.keys(value).every(function (nested) { | |||
| return self.merge(fullKey + ':' + nested, value[nested]); | |||
| return self.merge(common.key(fullKey, nested), value[nested]); | |||
There was a problem hiding this comment.
This change was just so that the only place where the : character is referenced is in common - plus, it seems like the right thing to do
|
Nice! I approve. @pksunkara Can you run tests and merge on this? I'm about to hit the hay. |
pksunkara
added a commit
that referenced
this pull request
Jun 21, 2012
Add support for nested configs via env
|
@pksunkara @jesusabdullah @mhart This introduced a pretty serious regression in #65. Be more careful in the future |
|
I really have no idea how this issue is at all related to #65, but the irony of telling people to Be more careful in the future is not lost on me. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to use nested config keys from env variables by specifying a custom separator (I believe this isn't currently possible because you can't use the
:character in env variable names).