Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag support for asana-api #7

Merged
merged 6 commits into from May 20, 2013
Merged

Add tag support for asana-api #7

merged 6 commits into from May 20, 2013

Conversation

ridget
Copy link
Contributor

@ridget ridget commented Nov 30, 2012

references issue #6

npm tests are passing -- code utilises your pre-existing test setup -- is the update test enough though for your liking?

have updated the docs accordingly

@ridget
Copy link
Contributor Author

ridget commented Nov 30, 2012

urgh, screwed up the history when i rebased. Apologies, will fix and resubmit.

@indexzero
Copy link
Owner

@ridget I can probably just cherry-pick those commits instead.

@indexzero
Copy link
Owner

As long as I don't need the merge commit

@ridget
Copy link
Contributor Author

ridget commented Nov 30, 2012

No, merge commit has nothing in there, was just merging from a rebased branch, was a conflict with README.md but didn't actually have to modify anything. I'm happy to just resubmit the pull request though, there's not that much to the above if its easier for you all around.

indexzero added a commit that referenced this pull request May 20, 2013
Add tag support for asana-api
@indexzero indexzero merged commit fd5b36d into indexzero:master May 20, 2013
@indexzero indexzero mentioned this pull request May 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants