Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Tabs component to auto-assign attribute values if none are provided #688

Merged
merged 15 commits into from Mar 17, 2023

Conversation

scottanthonymurray
Copy link
Contributor

No description provided.

Copy link
Member

@levimcg levimcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny comment here re: JSDoc comments on the removeTab method. Otherwise this looks great to me!

src/js/components/tabs.js Outdated Show resolved Hide resolved
@scottanthonymurray scottanthonymurray merged commit 4cc587e into 2.0.0-dev Mar 17, 2023
@scottanthonymurray scottanthonymurray deleted the feature/tabs-auto-attrs branch March 17, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants