Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gap utility #731

Merged
merged 3 commits into from Nov 17, 2023
Merged

Add gap utility #731

merged 3 commits into from Nov 17, 2023

Conversation

basham
Copy link
Member

@basham basham commented Nov 8, 2023

Notes:

  1. This adds rvt-gap-*, rvt-gap-col-* and rvt-gap-row-* utility classes.
  2. I feel like it makes sense to encourage the use of the rvt-gap-col-* and rvt-gap-row-* variants over rvt-gap-*, as that gives more explicit control over the styling. But I'm leaving rvt-gap-* for completeness.
  3. I added a $spacing variable to make it easy to loop through those tokens. There may be other areas that could use it, but that refactor would should be done in a different PR.
  4. Some of the larger spacing variants seem outlandish, but it also seems arbitrary to dictate which space values will be included. So, I've included all of them.
  5. I named it rvt-gap-col-* instead of rvt-gap-column-* to make it more succinct, even though the CSS property name is column-gap.
  6. Because gap can be used for both grid and flex, I did not categorize this under the flex utilities.

@basham
Copy link
Member Author

basham commented Nov 15, 2023

Reviewed the PR with @levimcg today. Decisions:

  • Add *-none variants (value is 0).

@basham
Copy link
Member Author

basham commented Nov 15, 2023

@levimcg: Ready for review.

@levimcg levimcg merged commit 77fd41a into indiana-university:2.0.0-dev Nov 17, 2023
@basham basham deleted the feature/gap branch November 17, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants