Shibboleth auth provider: return an identifier if identifier_field params is defined #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ram is defined - Allow to use the Shibboleth auth provider with the LDAP identity provider that requires the identifier to be defined
ThiefMaster
reviewed
Jan 4, 2021
| return self.multipass.handle_auth_success(AuthInfo(self, **attributes)) | ||
|
|
||
| # Define 'identifier' attribute if 'identifier_field' is defined. | ||
| # Required to use a LDAP identity provider with the SSO auth provider. |
There was a problem hiding this comment.
I think it would make more sense to make the identifier key on the ldap side configurable.
There was a problem hiding this comment.
I basically agree... But looking at the modification involved, I found easier to do it in the Shibboleth provider... That said, I could look again because it took me some time to understand that it was necessary to change the UID field too and the identifier part may be trivial (it was my initial implementation in fact !)
|
Replaced by #42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Indico documentation suggests that it is a good idea to use an LDAP identity provider, when you have one like AD, with a Shibboleth auth provider, to benefit from the group definitions coming from LDAP. Unfortunately it doesn't work because the LDAP identity provider is expecting the auth provider to return an
identifierattribute in theAuthInfoobject (as does the LDAP auth provider) but the Shibboleth auth provider doesn't.This PR proposes to use the
identifier_fieldparameter, normally used by identity providers, in the Shibboleth auth provider params as an indication that theAuthInfoidentifierattribute must be defined (with the Shibboleth attributed defined by the value ofidentifier_field). If this parameter is undefined, the behaviour of the Shibboleth auth provider is unchanged.This PR has been tested successfully at IJCLab. Note that the limitation is that every user authenticated through Shibboleth must has a matching account in LDAP (AD in our case). Supporting authentication for local and remote users through Shibboleth (eduGAIN for example) and using LDAP as the identity provider requires a modification of the LDAP provider (or a custom one) to build the identity from
AuthInfoattributes provided by Shibboleth when there is no LDAP match...