Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "quick cancel" link to room booking reminder emails #4324

Closed
ThiefMaster opened this issue Feb 27, 2020 · 0 comments · Fixed by #4331
Closed

Add "quick cancel" link to room booking reminder emails #4324

ThiefMaster opened this issue Feb 27, 2020 · 0 comments · Fixed by #4331
Assignees
Projects
Milestone

Comments

@ThiefMaster
Copy link
Member

ThiefMaster commented Feb 27, 2020

This link would show the booking details page, and immediately open a confirmation to cancel this particular occurrence.

Things to keep in mind:

  • you may click the link after the occurrence finished, so you cannot cancel it anymore. I'd just ignore it in that case and not show anything besides the normal booking details dialog
  • for a non-recurring booking including this link is not very useful since you can just cancel the booking itself

For the link in the email I'd use .../booking/<id>/cancel/<date>; and then just redirect to the normal booking details modal with another arg (see payload in ModalController) to specify the day that should be cancelled.

related: #4092 (comment)

@Leats Leats self-assigned this Feb 27, 2020
@ThiefMaster ThiefMaster added this to the v2.3 milestone Feb 28, 2020
@ThiefMaster ThiefMaster added this to To do in Release 2.3 via automation Feb 28, 2020
@ThiefMaster ThiefMaster moved this from To do to In progress in Release 2.3 Feb 28, 2020
@Leats Leats moved this from In progress to Review in progress in Release 2.3 Mar 2, 2020
Release 2.3 automation moved this from Review in progress to Done Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release 2.3
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants