Protected Event Registration Details for non-Indico accounts.

[vasantvohra]

Bug Description
When an event is protected and registration is added by the event manager as a new Indico user(registration) without an Indico account. Then, It is not possible to preview the registration details with link having token sent via email.

How to Reproduce
Steps to reproduce the behavior:

1. Create a new conference in any category,
2. From protection make the event 'Protected' (protection mode),
3. Create a new registration form,
4. Go to the registration list,
   Then, ➕ Register ➡️ New User ➡️ Fill the form with an email that doesn't have an Indico account ➡️ Send Email - True
5. Check Email ➡️ click on the link present in 'manage my registration'. Indico will redirect to the login page.

Expected behavior
Registration detail should be displayed from the registration link with a token (URL) irrespective of an event is protected or If the event is protected it shouldn't be possible to register someone without an Indico user account?

[vasantvohra]

I'm available on Indico matrix via Elements feel free to get in touch if doubts.
Thanks,
Vasant Vohra

[ThiefMaster]

Sounds indeed worth fixing as long as you just want to grant access to the registration-specific pages using the token.

I think the best solution would be to set a variable in RHRegistrationFormRegistrationBase._process_args when a valid registration token is used, and override _check_access in there to only call the superclass' method if no registration token has been used.

Do you want to send a PR (against master (Indico 3.0), since this is a very minor bug and we don't plan to make a new 2.3.x release)?

[vasantvohra]

yes sure, I'll send a PR.