Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoA TeX export #4035

Merged
merged 15 commits into from Sep 3, 2019
Merged

BoA TeX export #4035

merged 15 commits into from Sep 3, 2019

Conversation

mvidalgarcia
Copy link
Member

@mvidalgarcia mvidalgarcia commented Aug 20, 2019 •
edited by ThiefMaster

TODO:

  • Use BytesIO download the zip file directly instead of caching

@mvidalgarcia mvidalgarcia marked this pull request as ready for review August 20, 2019 13:55
ThiefMaster
ThiefMaster reviewed Aug 20, 2019
View reviewed changes
indico/legacy/pdfinterface/latex.py Outdated Show resolved Hide resolved
indico/modules/events/contributions/util.py Outdated Show resolved Hide resolved
@ThiefMaster
Copy link
Member

The spacing at the bottom looks strange now:

image

@mvidalgarcia
Copy link
Member Author

The spacing at the bottom looks strange now:

image

I think it slightly changed on master as well, maybe related with SUI? A comparative:

master:
image

Production:
image

@bpedersen2 bpedersen2 mentioned this pull request Aug 30, 2019
Closed
bpedersen2 and others added 12 commits September 2, 2019 10:18
@bpedersen2 @ThiefMaster
Improved TeX contribution list export
12f9a6e 
Handle different sort options and allow export of the generated tex
directory as zip-file as well.

For the zip export, run the normal processing and just zip up the
complete resulting folder.
We never abort in this case, even if the tex run fails as this may
help in debugging the tex problems.
@bpedersen2 @ThiefMaster
Add signal to get possible exporters
dd9fed5 
This allows to extend exporters via plugins
@bpedersen2 @ThiefMaster
Put fonts close to tex-source
b7b99d0 
Symlink or copy the fonts into the tex working dir.
This will later get used for exporting the fonts together with the
sources.
@bpedersen2 @ThiefMaster
Zip tex tmp-dir with subdirs
496cdb1 
As we now have the fonts in sub-dir, we want to get the complete
tree instead of just the top-level files.
@mvidalgarcia @ThiefMaster
Remove unused exports
79596a5
@mvidalgarcia @ThiefMaster
Fix BoA download and get rid of signal
04df350
@mvidalgarcia @ThiefMaster
Remove unused template
9719d25
@mvidalgarcia @ThiefMaster
Add BoA TeX download link in management area
e411366
@mvidalgarcia @ThiefMaster
Use more meaningful variable names
b07f83f
@mvidalgarcia @ThiefMaster
Remove exception handling
dc7b81d
@mvidalgarcia @ThiefMaster
Make LaTeX source files only available to managers
f4e5abe
@ThiefMaster
Add changelog entry
b5c654c
@ThiefMaster ThiefMaster merged commit 43a60ad into indico:master Sep 3, 2019
@mvidalgarcia mvidalgarcia deleted the boa-tex branch September 25, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiefMaster ThiefMaster ThiefMaster left review comments

@mic4ael mic4ael mic4ael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mvidalgarcia @ThiefMaster @mic4ael @bpedersen2