Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add placeholder block cat_filter_extra (category overview) #4428

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Add placeholder block cat_filter_extra (category overview) #4428

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
468c7a1
Add placeholder block cat_filter_extra (category overview)
marengeti Apr 27, 2020
1247527
Renaming placeholder block to category_filter_extra
marengeti Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions indico/modules/categories/templates/display/overview/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ <h3>{% trans %}Display options{% endtrans %}</h3>
</select>
</div>
</div>
{% block cat_filter_extra %}{% endblock %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the name could be improved a bit? category_extra_filters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, if you prefer that, done. I was unable to project a clear block naming convention from the block names I see?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a separate commit though ;) You can squash them into one :)

Copy link
Contributor Author

@marengeti marengeti Apr 28, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be squashed on merge.

</div>
<span id="applyButtonWrapper">
<input class="i-button" type="submit" value="{% trans %}Apply{% endtrans %}">
Expand Down