Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor colorclass #5061

Merged
merged 7 commits into from Sep 8, 2021
Merged

Vendor colorclass #5061

merged 7 commits into from Sep 8, 2021

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Aug 27, 2021

Closes #4862

Incorporates the archived colorclass library release 2.2.0 into Indico.
Unused code and compatibility with python2 is removed.

@tomasr8 tomasr8 force-pushed the vendor-colorclass branch 3 times, most recently from e222ae8 to 2629c61 Compare August 30, 2021 14:09
@tomasr8 tomasr8 marked this pull request as ready for review August 30, 2021 14:23
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add indico/vendor/* linguist-vendored to .gitattributes so GitHub knows this is vendored code and collapses it e.g. in PR diffs by default

indico/util/console.py Outdated Show resolved Hide resolved
indico/util/benchmark.py Outdated Show resolved Hide resolved
indico/vendor/colorclass/__init__.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster added this to the v3.1 milestone Sep 8, 2021
@ThiefMaster ThiefMaster merged commit 8410ee5 into indico:master Sep 8, 2021
@ThiefMaster ThiefMaster deleted the vendor-colorclass branch September 8, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace colorclass with something else
2 participants