Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude unlisted events from internal search #5761

Merged

Conversation

ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented May 8, 2023

Returning them fails because the category is not optional in the various schemas, and we never intended to return such content in the search anyway.

closes #5760
fixes #5759

Returning them fails because the category is not optional in the various
schemas, and we never intended to return such content in the search
anyway.
@ThiefMaster ThiefMaster added this to the v3.2 milestone May 8, 2023
@bpedersen2
Copy link
Contributor

Looks good to me

@bpedersen2
Copy link
Contributor

Confirmed it works in my test case

@ThiefMaster ThiefMaster merged commit 47e2cb3 into indico:master May 8, 2023
9 checks passed
@ThiefMaster ThiefMaster deleted the fix-internal-search-unlisted branch May 8, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal search does get None sometimes
2 participants