Allow deleting editables #5778
Merged
Allow deleting editables #5778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
May 18, 2023
indico/modules/events/editing/controllers/backend/management.py
Outdated
Show resolved
Hide resolved
duartegalvao
force-pushed
the
delete-editables
branch
5 times, most recently
from
ef821df
to
e25a284
Compare
ThiefMaster
reviewed
May 22, 2023
indico/modules/events/editing/client/js/editing/timeline/DeleteEditable.jsx
Outdated
Show resolved
Hide resolved
duartegalvao
force-pushed
the
delete-editables
branch
from
e25a284
to
fb0f3a7
Compare
tomasr8
reviewed
Jun 2, 2023
indico/migrations/versions/20230515_1145_cb46beecbb93_add_editable_is_deleted.py
Outdated
Show resolved
Hide resolved
tomasr8
reviewed
Jun 2, 2023
indico/migrations/versions/20230515_1145_cb46beecbb93_add_editable_is_deleted.py
Outdated
Show resolved
Hide resolved
duartegalvao
force-pushed
the
delete-editables
branch
from
fb0f3a7
to
70bacd2
Compare
|
Just leaving this here, so we don't forget. We're getting this react warning when deleting editables, though it doesn't happen always.
|
duartegalvao
force-pushed
the
delete-editables
branch
from
70bacd2
to
6c8bf33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows event managers to fully (soft-)delete editables from contributions, allowing submitters to restart the editing process from scratch.
Progress:
Editable.is_deletedattribute