New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make language list more accessible #5903
Conversation
d52205f
to
7a8dde0
Compare
For now I'm going to leave the conversion to a |
7a8dde0
to
0e20e9c
Compare
Besides those small issues it looks and works really well though! |
Just noticed that this is likely intentional ("Increase target surface area of the language buttons") so nevermind. |
This is to increase their target size. Since we're not touching font sizes as of right now, it looks larger than it should be. Ideally I would also increase the font size. |
28eaedc
to
c9bbf26
Compare
- Fix the button markup (change A to BUTTON) - Add lang attribute as appropriate - Expand the ARIA label for the menu button (NOTE: i18n needed) - Increase target surface area of the language buttons
c9bbf26
to
a895e0e
Compare
Fixes #5899