Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make language list more accessible #5903

Merged
merged 2 commits into from Aug 30, 2023
Merged

Conversation

foxbunny
Copy link
Collaborator

@foxbunny foxbunny commented Aug 23, 2023

  • Fix the button markup (change A to BUTTON)
  • Add lang attribute as appropriate
  • Expand the ARIA label for the menu button (NOTE: i18n needed)
  • Increase target surface area of the language buttons

Fixes #5899

@foxbunny foxbunny marked this pull request as ready for review August 23, 2023 10:47
@foxbunny
Copy link
Collaborator Author

For now I'm going to leave the conversion to a <form> alone. I'll first convert the session bar into a pull-down menu as we've discussed, and then I'll circle back to this.

indico/web/templates/_session_bar.html Outdated Show resolved Hide resolved
indico/web/templates/_session_bar.html Outdated Show resolved Hide resolved
indico/web/templates/_session_bar.html Outdated Show resolved Hide resolved
@ThiefMaster
Copy link
Member

ThiefMaster commented Aug 23, 2023

Besides those small issues it looks and works really well though! Only thing I'd look into is changing the padding/margin of the individual language entries a bit, they feel larger than before.

@ThiefMaster
Copy link
Member

Only thing I'd look into is changing the padding/margin of the individual language entries a bit, they feel larger than before.

Just noticed that this is likely intentional ("Increase target surface area of the language buttons") so nevermind.

@foxbunny
Copy link
Collaborator Author

Besides those small issues it looks and works really well though! Only thing I'd look into is changing the padding/margin of the individual language entries a bit, they feel larger than before.

This is to increase their target size. Since we're not touching font sizes as of right now, it looks larger than it should be. Ideally I would also increase the font size.

@foxbunny foxbunny force-pushed the color-contrast branch 2 times, most recently from 28eaedc to c9bbf26 Compare August 23, 2023 12:12
CHANGES.rst Outdated Show resolved Hide resolved
foxbunny and others added 2 commits August 30, 2023 12:56
- Fix the button markup (change A to BUTTON)
- Add lang attribute as appropriate
- Expand the ARIA label for the menu button (NOTE: i18n needed)
- Increase target surface area of the language buttons
@ThiefMaster ThiefMaster enabled auto-merge (squash) August 30, 2023 11:00
@ThiefMaster ThiefMaster added this to the v3.3 milestone Aug 30, 2023
@ThiefMaster ThiefMaster merged commit 4639515 into indico:master Aug 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11Y] Language selector markup
2 participants