Add support for picture field in registration forms #5922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indico/web/client/js/react/components/pictures/PictureWebcam.jsx
Outdated
Show resolved
Hide resolved
ThiefMaster
reviewed
Sep 11, 2023
indico/web/client/js/react/components/pictures/PictureManager.jsx
Outdated
Show resolved
Hide resolved
SegiNyn
force-pushed
the
regform-picture-field
branch
from
e48803e
to
657bd10
Compare
SegiNyn
force-pushed
the
regform-picture-field
branch
from
657bd10
to
f805106
Compare
SegiNyn
force-pushed
the
regform-picture-field
branch
3 times, most recently
from
5311d0c
to
a0a95d1
Compare
SegiNyn
force-pushed
the
regform-picture-field
branch
from
a0a95d1
to
545f1bd
Compare
ThiefMaster
reviewed
Oct 31, 2023
indico/modules/events/registration/templates/display/_registration_summary_blocks.html
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/pictures/PictureCropper.jsx
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/pictures/PictureCropper.jsx
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/pictures/PictureCropper.jsx
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/pictures/PictureCropper.jsx
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/pictures/PictureManager.jsx
Outdated
Show resolved
Hide resolved
SegiNyn
force-pushed
the
regform-picture-field
branch
3 times, most recently
from
b89a538
to
80a090e
Compare
SegiNyn
force-pushed
the
regform-picture-field
branch
from
80a090e
to
96f9cb9
Compare
ThiefMaster
reviewed
Nov 13, 2023
ThiefMaster
reviewed
Nov 13, 2023
SegiNyn
force-pushed
the
regform-picture-field
branch
from
82bdcf4
to
38e5bf5
Compare
ThiefMaster
reviewed
Nov 16, 2023
SegiNyn
force-pushed
the
regform-picture-field
branch
from
38e5bf5
to
62ca7f3
Compare
SegiNyn
force-pushed
the
regform-picture-field
branch
2 times, most recently
from
78fe34a
to
189d837
Compare
ThiefMaster
reviewed
Jan 15, 2024
indico/web/client/js/react/components/pictures/PictureManager.jsx
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/pictures/PictureManager.jsx
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/pictures/PictureManager.jsx
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/pictures/PictureManager.jsx
Outdated
Show resolved
Hide resolved
SegiNyn
force-pushed
the
regform-picture-field
branch
from
189d837
to
17b14a0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
SegiNyn
commented
Jan 16, 2024
indico/modules/events/registration/client/js/form/fields/PictureInput.jsx
Outdated
Show resolved
Hide resolved
ThiefMaster
reviewed
Jan 17, 2024
indico/web/client/js/react/components/pictures/PictureManager.jsx
Outdated
Show resolved
Hide resolved
|
The alignment of those buttons is rather weird |
This comment was marked as resolved.
This comment was marked as resolved.
|
The first click on the "Rotate" button doesn't do anything |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ThiefMaster
force-pushed
the
regform-picture-field
branch
from
1f83d17
to
1d12300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Support for Picture Field in registration Forms.
It works similar to the
SingleFileManagercomponent, with the addition that it accepts only images, allows to display the uploaded image, allows to capture image from Camera and Crop image.2 libraries were used:
https://www.npmjs.com/package/react-webcam and
https://www.npmjs.com/package/react-cropper