Add Google Wallet integration #6028

openprojects · 2023-11-09T14:25:35Z

Add Google Wallet integration.

Google Wallet Event ticket preview:

indico/modules/events/__init__.py

indico/modules/events/registration/blueprint.py

indico/modules/events/registration/badges.py

ThiefMaster · 2023-11-13T14:44:25Z

You accidentally pushed an empty branch. To recover this without having to open a new PR (assuming origin is your remote):

git push --force origin 010d0293235:Add-Google-Wallet-integration
Now the "reopen" button should be available here

(010d0293235 is the "Move GoogleWalletManager class to separate file" commit you pushed earlier today)

Then to properly sync it with master:

git fetch upstream
git rebase upstream/master
git push --force

openprojects · 2023-11-13T14:45:34Z

YES, Thank you!! Fixing it….

indico/modules/events/registration/templates/display/registration_summary.html

indico/modules/events/registration/templates/display/conference_home.html

indico/modules/events/registration/google_wallet.py

indico/migrations/versions/20231107_0956_492c6d801a4a_add_google_wallet_integration.py

indico/modules/categories/controllers/management.py

tomasr8 · 2023-11-22T16:11:14Z

@openprojects Could you please rebase the PR (and update the migration)? thanks!

indico/modules/events/models/events.py

indico/modules/categories/controllers/management.py

indico/modules/events/registration/google_wallet.py

indico/modules/events/registration/templates/display/registration_summary.html

indico/modules/events/registration/controllers/display.py

indico/migrations/versions/20231107_0956_492c6d801a4a_add_google_wallet_integration.py

tomasr8 · 2024-01-31T09:59:42Z

@openprojects Could you rebase the PR? :)

openprojects · 2024-01-31T15:20:15Z

@openprojects Could you rebase the PR? :)

Done.

tomasr8 · 2024-01-31T15:24:41Z

@openprojects Could you rebase the PR? :)

Done.

Could you rebase instead of merging master? We try to avoid merge commits to keep the history clean

ThiefMaster · 2024-01-31T15:27:29Z

And while we usually squash-and-merge PRs anyway, it's way easier if we can do a quick git rebase master locally for testing (at least I always do that to test on the latest version regardless of how fresh the PR 's branch is)

openprojects · 2024-02-01T08:46:01Z

@openprojects Could you rebase the PR? :)

Done.

Could you rebase instead of merging master? We try to avoid merge commits to keep the history clean

Working on it...

tomasr8 · 2024-02-01T09:19:20Z

@openprojects Could you rebase the PR? :)

Done.

Could you rebase instead of merging master? We try to avoid merge commits to keep the history clean

Working on it...

Try this:

git checkout Add-Google-Wallet-integration
git reset --hard HEAD~3  # To remove the last 3 commits which shouldn't be there
git fetch upstream
git rebase upstream/master
git push -f origin Add-Google-Wallet-integration

indico/modules/events/registration/google_wallet.py

- better naming - util to prepend issuer id part

It should never change, but by saving it in the event settings we know for which events a ticket class can been created. That may come in handy in the future...

indico/modules/categories/forms.py

indico/modules/categories/controllers/management.py

indico/modules/events/registration/forms.py

indico/modules/events/registration/google_wallet.py

indico/modules/events/registration/models/registrations.py

Co-authored-by: Alejandro Avilés <omegak@gmail.com>

also use an enum for it instead of this hack of mapping between boolean/none and strings

ThiefMaster · 2024-02-26T16:30:49Z

Final TODOs for later or tomorrow before this this is finally getting merged:

Expose event logo via secret (signed) URL so even private events can have their logo in Google Wallet
Mention that wallet tickets are not available for accompanying persons?
Warn when exactly one of address/venue are set and wallet tickets are enabled
Separate setting for wallet logo URL? Also super useful for developers whose instance is not accessible by Google's servers

GW requires both to show it

It gets squeezed into a square so the default logo with the full "Indico" text looks really weird

openprojects force-pushed the Add-Google-Wallet-integration branch 3 times, most recently from 2653814 to 7f7a84a Compare November 9, 2023 17:01

ThiefMaster reviewed Nov 9, 2023

View reviewed changes

openprojects marked this pull request as ready for review November 9, 2023 20:35

openprojects closed this Nov 13, 2023

openprojects force-pushed the Add-Google-Wallet-integration branch from dafec5a to 57a496e Compare November 13, 2023 14:40

openprojects reopened this Nov 13, 2023

ThiefMaster reviewed Nov 17, 2023

View reviewed changes

tomasr8 reviewed Nov 22, 2023

View reviewed changes

indico/modules/events/models/events.py Outdated Show resolved Hide resolved

indico/modules/categories/controllers/management.py Outdated Show resolved Hide resolved

indico/modules/events/registration/google_wallet.py Outdated Show resolved Hide resolved

openprojects force-pushed the Add-Google-Wallet-integration branch from f839e20 to f5e8f96 Compare November 23, 2023 08:56

openprojects requested a review from tomasr8 November 23, 2023 09:48

tomasr8 reviewed Nov 27, 2023

View reviewed changes

indico/modules/events/registration/google_wallet.py Outdated Show resolved Hide resolved

tomasr8 reviewed Nov 27, 2023

View reviewed changes

tomasr8 reviewed Nov 28, 2023

View reviewed changes

indico/migrations/versions/20231107_0956_492c6d801a4a_add_google_wallet_integration.py Outdated Show resolved Hide resolved

openprojects requested a review from tomasr8 November 28, 2023 15:08

openprojects requested a review from ThiefMaster January 29, 2024 10:39

openprojects force-pushed the Add-Google-Wallet-integration branch from e08c595 to 3b8fe26 Compare January 31, 2024 16:01

GovernmentPlates reviewed Feb 1, 2024

View reviewed changes

indico/modules/events/registration/google_wallet.py Outdated Show resolved Hide resolved

openprojects force-pushed the Add-Google-Wallet-integration branch 2 times, most recently from 6a4213a to 4349e6b Compare February 1, 2024 09:43

Improve logic whether to update class/ticket

cd06010

ThiefMaster approved these changes Feb 25, 2024

View reviewed changes

ThiefMaster added 8 commits February 26, 2024 10:43

Refactor google id generation

e5dc4cb

- better naming - util to prepend issuer id part

Move baase API URLs outside GWM class

4a7b71c

Improve category field descriptions

3d5ff47

Use shorter key for google credentials

21509ac

Update docstring

c871c82

Bail out early if GW is disabled

44b9a40

Refactor GWM credentials init

e38a87f

Persist ticket class ID

23eb414

It should never change, but by saving it in the event settings we know for which events a ticket class can been created. That may come in handy in the future...

OmeGak reviewed Feb 26, 2024

View reviewed changes

Fix field description

396c4b3

Co-authored-by: Alejandro Avilés <omegak@gmail.com>

ThiefMaster force-pushed the Add-Google-Wallet-integration branch from 99d3fb6 to 396c4b3 Compare February 26, 2024 13:05

Add another warning to category settings

2711416

ThiefMaster self-assigned this Feb 26, 2024

ThiefMaster added 4 commits February 26, 2024 16:31

Move google_wallet_mode into its own column

62624f0

also use an enum for it instead of this hack of mapping between boolean/none and strings

Use CTE to lookup effective wallet config

29d6315

Do not choke on unlisted events

9798c91

Clarify ID storage

cae88eb

ThiefMaster added 4 commits February 26, 2024 17:36

Clarify that GW does not work for accompanying persons

f3906d6

Use signed URL to allow using logo from protected events

13d90f7

Warn if partial location info is provided

227a28d

GW requires both to show it

Add extra setting for wallet logo

9c176e7

ThiefMaster added this to the v3.3 milestone Feb 26, 2024

ThiefMaster force-pushed the Add-Google-Wallet-integration branch from 8573e81 to 960c133 Compare February 26, 2024 18:29

ThiefMaster enabled auto-merge (squash) February 26, 2024 18:30

Use better default wallet logo

856bd7e

It gets squeezed into a square so the default logo with the full "Indico" text looks really weird

ThiefMaster force-pushed the Add-Google-Wallet-integration branch from 960c133 to 856bd7e Compare February 26, 2024 18:59

ThiefMaster merged commit b509a5e into indico:master Feb 26, 2024
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Google Wallet integration #6028

Add Google Wallet integration #6028

openprojects commented Nov 9, 2023 •

edited

ThiefMaster commented Nov 13, 2023

openprojects commented Nov 13, 2023 via email •

edited by ThiefMaster

tomasr8 commented Nov 22, 2023 •

edited

tomasr8 commented Jan 31, 2024

openprojects commented Jan 31, 2024

tomasr8 commented Jan 31, 2024 •

edited

ThiefMaster commented Jan 31, 2024

openprojects commented Feb 1, 2024

tomasr8 commented Feb 1, 2024

ThiefMaster commented Feb 26, 2024 •

edited

Add Google Wallet integration #6028

Add Google Wallet integration #6028

Conversation

openprojects commented Nov 9, 2023 • edited

ThiefMaster commented Nov 13, 2023

openprojects commented Nov 13, 2023 via email • edited by ThiefMaster

tomasr8 commented Nov 22, 2023 • edited

tomasr8 commented Jan 31, 2024

openprojects commented Jan 31, 2024

tomasr8 commented Jan 31, 2024 • edited

ThiefMaster commented Jan 31, 2024

openprojects commented Feb 1, 2024

tomasr8 commented Feb 1, 2024

ThiefMaster commented Feb 26, 2024 • edited

openprojects commented Nov 9, 2023 •

edited

openprojects commented Nov 13, 2023 via email •

edited by ThiefMaster

tomasr8 commented Nov 22, 2023 •

edited

tomasr8 commented Jan 31, 2024 •

edited

ThiefMaster commented Feb 26, 2024 •

edited