Create new setting for booking reason required - #6155
Merged
Conversation
ThiefMaster
reviewed
Jan 30, 2024
moliholy
force-pushed
the
booking-reason-required
branch
from
February 1, 2024 19:25
876d622 to
400685b
Compare
moliholy
marked this pull request as ready for review
February 1, 2024 19:27
Contributor
Author
|
@ThiefMaster ready for review! |
ThiefMaster
reviewed
Feb 1, 2024
ThiefMaster
force-pushed
the
booking-reason-required
branch
from
February 9, 2024 14:49
6362187 to
0021683
Compare
Member
|
Some issues I noticed while testing:
|
Contributor
Author
Both of them are now addressed. |
ThiefMaster
reviewed
Feb 11, 2024
moliholy
force-pushed
the
booking-reason-required
branch
from
February 12, 2024 11:31
044ad95 to
e447479
Compare
ThiefMaster
reviewed
Feb 12, 2024
Member
|
Needs a changelog entry :) - Add setting to configure whether room bookings require a reason (:issue:`6150`, :pr:`6155`,
thanks :user:`Moliholy, unconventionaldotdev`) |
Contributor
Author
Added 😄 |
ThiefMaster
force-pushed
the
booking-reason-required
branch
from
February 12, 2024 14:17
7ca46ed to
3108451
Compare
During creation we filter it out, but during edit this must be done manually to get a nicer validation error instead of "field cannot be null"
We always pass something from the selector
ThiefMaster
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6150
Room booking: reason required configuration
This PR allows to set a configuration parameter to determine whether specifying a reason for a booking is mandatory or not.
Screenshots