New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new setting for booking reason required #6155
Conversation
876d622
to
400685b
Compare
@ThiefMaster ready for review! |
6362187
to
0021683
Compare
Some issues I noticed while testing:
|
Both of them are now addressed. |
044ad95
to
e447479
Compare
Needs a changelog entry :) - Add setting to configure whether room bookings require a reason (:issue:`6150`, :pr:`6155`,
thanks :user:`Moliholy, unconventionaldotdev`) |
Added 😄 |
7ca46ed
to
3108451
Compare
During creation we filter it out, but during edit this must be done manually to get a nicer validation error instead of "field cannot be null"
We always pass something from the selector
Closes #6150
Room booking: reason required configuration
This PR allows to set a configuration parameter to determine whether specifying a reason for a booking is mandatory or not.
Screenshots