New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pkg_resources with importlib #6273
Conversation
I recommend not putting the issue reference in the commit message itself but only in the PR description. Otherwise it spams one line of being referenced into the issue whenever you rebase and forcepush. Not a big problem but slightly noisy. |
f33743a
to
1671c73
Compare
Please run What do you think about using https://pypi.org/project/importlib-metadata/ instead of the stdlib one to avoid any nasty surprises with Python version updates? Or is the API of the stdlib version stable enough now? At least when I moved some of our libraries from |
1671c73
to
cdaafe7
Compare
`version` is REALLY REALLY generic...
11c89bb
to
5f69146
Compare
d60719b
to
f2a9c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works fine!
closes #6272