Send email notification when a new instance is registered & allow boolean values #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
requested changes
Jul 21, 2017
cephalopod/api/instance.py
Outdated
| from sqlalchemy.exc import SQLAlchemyError | ||
|
|
||
| from cephalopod.utils import send_email |
There was a problem hiding this comment.
relative import until we change them all
| @@ -0,0 +1,8 @@ | |||
| A new instance has been registered | |||
| Contact: {{ instance.contact }} | ||
| Email: {{ instance.email }} | ||
|
|
||
| {{ url_for('frontend.get_server', id=instance.id, _external=True) }} |
requirements.txt
Outdated
| @@ -21,3 +21,4 @@ psycopg2==2.7.1 | |||
| libsass==0.12.3 | |||
| IPython | |||
| flask-shell-ipython | |||
| Flask-Mail==0.9.1 | |||
There was a problem hiding this comment.
i'd move this up next to the other Flask-* packages
cephalopod/utils.py
Outdated
| @@ -7,6 +7,9 @@ | |||
| import pkg_resources | |||
| from flask import current_app | |||
| from flask.helpers import get_root_path | |||
| from flask_mail import Message | |||
|
|
|||
| from cephalopod.core import mail | |||
There was a problem hiding this comment.
might be safer to move this import inside the function. i wouldn't expect utils to import core
mvidalgarcia
force-pushed
the
new-instance-email
branch
from
f4c9e87
to
80a80de
Compare
E.g. debug mode
mvidalgarcia
changed the title
ThiefMaster
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.