-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different styling for Loqi posts in original vs live fetched lines #31
Comments
Is this on chat.indieweb.org, or indieweb.org/irc? |
chat.indieweb.org |
Some more poking results in the following observations: Permalinks and day-pages show the same issue. format_line is called in all paths (searching for it shows the expected 4 hits) copy-pasting a wiki-edit log line into my IRC client (as done here) provides a correctly formatted wiki edit, which again goes away if loaded from the database. (it also doesn't show that I did that, apparently wiki edit formatting doen'ts care if they come from Loqi or a random user. Worthy an issue or not?) This means that a whatever comes out of the database, processed by inc.php/filtertext() and my browser is correctly formatted to be accepted as a wiki line. I see two theories right now I can't really verify without more data: a) Whatever is returned by db_row_to_new_log is not an acceptable wiki line (does not match the regex), but roundtripping it through filtertext somehow corrects this. Not debuggable from the outside. b) format_wiki_line begins with a check of |
I just updated https://github.com/indieweb/chat.indieweb.org/blob/master/lib/config.template.php |
The issue is related to the naming for the channels, but differently than I thought. The issue is that you pass two different values for
(In the main channel it is Suggestions for fixing itChange it so that Then have log.php pass In general, cleaning up channel names and the logic around them would help improve the code. E.g. code dealing with the #indiewebcamp->#indieweb transition exists in more than one place, channel names and slugs are transformed into each other locally (e.g. by prepending |
Compare:
and
The second line was dynamically loaded after I opened the page, and has nicer formatting for the wiki edit. If I reload the page, it looses this. Presumably, it should look the same in both cases.
The text was updated successfully, but these errors were encountered: