Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require explicitly specifying redirect_uri instead of allowing same-host URIs by default? #122

Open
saschanaz opened this issue Apr 9, 2023 · 1 comment

Comments

@saschanaz
Copy link

saschanaz commented Apr 9, 2023

Section 4.2.2 says:

If a client wishes to use a redirect URL that has a different host than their client_id, or if the redirect URL uses a custom scheme (such as when the client is a native application), then the client will need to explicitly list those redirect URLs so that authorization endpoints can be sure it is safe to redirect users there.

I wonder the following situation is possible:

  1. The author user of the client my-client thinks GitHub Pages https://user.github.io/my-client should be enough for the client ID as there's only one person who has the access for that origin at that point.
  2. The author later does some collaboration with other people for a project named our-project but without setting up an organization. Now other people has access to https://user.github.io/our-project which is an implicitly allowed redirect URI by IndieAuth.

Also, some provider libraries only support exact URI matching since OAuth 2.0 Security Best Current Practice recommends that.

@jalcine
Copy link

jalcine commented Nov 27, 2023

That'd be fixed then by moving the project to an organization, no?

I am in favor of doing a strict check though, that's just a lot easier to deal with.

(Originally published at: https://jacky.wtf/2023/11/A93v)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants