Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to add client_id to ticket auth requests? #85

Open
aaronpk opened this issue Jul 10, 2021 · 3 comments
Open

Do we need to add client_id to ticket auth requests? #85

aaronpk opened this issue Jul 10, 2021 · 3 comments
Labels
ticketing extension Ticketing for IndieAuth extension

Comments

@aaronpk
Copy link
Member

aaronpk commented Jul 10, 2021

No description provided.

@aaronpk aaronpk added the ticketing extension Ticketing for IndieAuth extension label Jul 10, 2021
@dshanske
Copy link
Member

I would think not as you are offering it to the site. Now, what we could do is add that to the ticket grant type to the token endpoint, so you could request that the ticket be issued and limited to a specific client.

@Zegnat
Copy link
Member

Zegnat commented Jul 10, 2021

My backend currently stores the discovered ticket_endpoint as the client_id on issued tokens. This value can be retrieved through token verification. (Maybe, unless I broke something there.)

This gives some of the same benefits as I would otherwise have from a client_id. E.g.: if a client goes rogue I can revoke all tokens ever issued to it, now if a ticket endpoint goes rogue I can do the same.

@dshanske
Copy link
Member

I've tried to address this by adding the notation about the grant_type supporting client_id, so the ticket endpoint, when redeeming, can opt to limit it to a specific client_id at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ticketing extension Ticketing for IndieAuth extension
Development

No branches or pull requests

3 participants