Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query for Location/Venue #6

Open
dshanske opened this issue Nov 26, 2018 · 9 comments

Comments

@dshanske
Copy link
Member

commented Nov 26, 2018

Brainstorming the proposed extension of querying for venues. The proposal https://indieweb.org/Micropub-brainstorming#Query_for_places uses q=geo=uri or :uri which seems confusing. I'd personally rather pass through individual parameters, lat, lon, u to query for.

q=geo&lat=10&lon=20 etc

Suggesting two return variables...

geo, indicating a default suggestion for the location and venues, indicating a series of possible venue suggestions. Not all sites would implement both. So, this would allow for simple location retrieval or a venue picker for check-ins to a url.

Return format for location would be name, lat, lon, optionally a full h-adr.

@dshanske

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2018

I have implemented a basic version of this for testing.

It supports the variables lat and lon or a single variable uri for geo URIs. There are two returns, venues or geo. Geo is a suggested location, venues would be a list of possible nearby venues. I am not returning any yet. And my return doesn't include specific properties for the location, even though I outlined that above. Just a name property.

{
"venues":[],
"geo":{
"name":"Queens, NY, USA","latitude":"xxxx","longitude":"yyyyy"}
}

@dshanske

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2019

It should be label, not name on the return as it is supposed to be an h-adr

@dshanske

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

Expanding on this thought to propose the following query choices..In all cases, q must equal geo, but, optional query parameters should be either:

  • uri - a GEO URI, for example geo:37.786971,-122.399677;u=35
    or:
  • lat and lat - latitude and longitude coordinates specified individually
  • u as an optional uncertainty/accuracy parameter

I think allowing both of these would be preferable.

@dshanske

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

Outlined an example return. All returns would follow the common properties of an h-adr object with only label and latitude/longitude being mandatory. The visibility property would reflect the experimental location-visibility Micropub property outlined on the extensions page.

{ "geo": [ "label" : "123 Main Street", "latitude": "18.1123", "longitude": "-72.1933", "visibility": "public", ], "venues": [ { "label" : "Main Street Apothecary", "latitude": "18.1123", "longitude": "-72.1931", "url": "https://example.com/venues/apothecary", }, { "label" : "Main Street Market", "latitude": "18.1123", "longitude": "-72.1931", "url": "https://example.com/venues/market", }, ] }

@swentel

This comment has been minimized.

Copy link

commented Mar 6, 2019

The Drupal module now supports q=geo too. Geo is returned, if anything is found of course. Venues not yet, but that will come once I started on Indigenous supporting venues selection.

@swentel

This comment has been minimized.

Copy link

commented Mar 6, 2019

Oh, re: query parameters - I'd love to just keep one format. Currently latitude and longitude as query params are used in the Drupal module too. Makes it less complex imo.

@swentel

This comment has been minimized.

Copy link

commented Mar 7, 2019

As for 'venues' property in the response, maybe that should be 'places' ?

@dshanske

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

I'm fine with it being places. No one has implemented it yet anyway.

Also, I prefer the individual parameters myself.

@swentel

This comment has been minimized.

Copy link

commented Mar 8, 2019

Ok, the Drupal module documents to return an array of 'places' now, see swentel/indieweb#393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.