Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndieAuth Plugin and Micropub Plugin #96

Closed
dshanske opened this issue Jan 1, 2018 · 6 comments
Closed

IndieAuth Plugin and Micropub Plugin #96

dshanske opened this issue Jan 1, 2018 · 6 comments

Comments

@dshanske
Copy link
Member

dshanske commented Jan 1, 2018

Since I'm working on IndieAuth support in the IndieAuth Plugin, invariably, we might end up with a conflict as I iterate. Wanted to open an issue to discuss possibilities.

https://github.com/indieweb/wordpress-indieauth/

  1. Right now, Micropub preempts WordPress if the micropub query variable is set and launches into a completely different set of code, so it will not be affected by the code I have hooking into determine_current_user which duplicates the same functionality.
  2. It uses 'indieauth_token_endpoint' and 'indieauth_authorization_endpoint' as option names. Should be easy to look there and fall back on the declaration if they aren't set.

I'm not sure if it is worth making it so Micropub uses the Indieauth plugin version of the code over the built in one.

@snarfed
Copy link
Member

snarfed commented Jan 2, 2018

thanks for discussing ahead of time! all this analysis makes sense and sounds good to me.

@snarfed
Copy link
Member

snarfed commented Jan 2, 2018

btw this looks similar to #85? let's maybe close one or the other.

@dshanske
Copy link
Member Author

dshanske commented Jan 2, 2018

That is about mf2 whereas this is about Indieauth

@snarfed
Copy link
Member

snarfed commented Jan 2, 2018

oops, sorry, i mistyped. i meant #84.

@dshanske
Copy link
Member Author

dshanske commented Jan 2, 2018

It is, but now it has been done

@snarfed
Copy link
Member

snarfed commented Jan 2, 2018

great! closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants