Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #11

Merged
merged 3 commits into from May 23, 2015
Merged

Fix build #11

merged 3 commits into from May 23, 2015

Conversation

achanda
Copy link
Contributor

@achanda achanda commented May 22, 2015

No description provided.

Subtracting from a large constant reverses the order
@achanda
Copy link
Contributor Author

achanda commented May 22, 2015

@shailesh1729 this seems to be building with stable. Any idea why? The .travis.yml file says nightly

@shailesh1729
Copy link
Contributor

I haven't checked for 3-4 weeks. Earlier, some of the features were not
working with the Rust Beta release. Hence, I had to use the nightly builds.
Are you interested in contributing more?

On Fri, May 22, 2015 at 2:10 PM, Abhishek Chanda notifications@github.com
wrote:

@shailesh1729 https://github.com/shailesh1729 this seems to be building
with stable. Any idea why? The .travis.yml file says nightly


Reply to this email directly or view it on GitHub
#11 (comment).

@achanda
Copy link
Contributor Author

achanda commented May 22, 2015

Sure, I can take a look whenever I can.

@shailesh1729
Copy link
Contributor

My skype id is shailesh.kumar.in . Let's chat some time.

On Fri, May 22, 2015 at 5:13 PM, Abhishek Chanda notifications@github.com
wrote:

Sure, I can take a look whenever I can.


Reply to this email directly or view it on GitHub
#11 (comment).

@achanda
Copy link
Contributor Author

achanda commented May 23, 2015

@shailesh1729 will do.
This patch fixes the build and all tests pass. You want to merge it now?

@shailesh1729
Copy link
Contributor

I will.

On Sat, May 23, 2015 at 9:46 PM, Abhishek Chanda notifications@github.com
wrote:

@shailesh1729 https://github.com/shailesh1729 will do.
This patch fixes the build and all tests pass. You want to merge it now?


Reply to this email directly or view it on GitHub
#11 (comment).

shailesh1729 added a commit that referenced this pull request May 23, 2015
@shailesh1729 shailesh1729 merged commit 57e4130 into indigits:master May 23, 2015
@shailesh1729
Copy link
Contributor

It's done.

@shailesh1729
Copy link
Contributor

Thanks a lot for the help :) The structure of the library is still
evolving. I want it to be strongly grounded in fundamental math concepts
and take as much advantage of the Rust generics as possible. Not sure where
this effort will reach. But hopefully something good will come out of it.

On Sat, May 23, 2015 at 10:34 PM, Shailesh Kumar shailesh@indigits.com
wrote:

I will.

On Sat, May 23, 2015 at 9:46 PM, Abhishek Chanda <notifications@github.com

wrote:

@shailesh1729 https://github.com/shailesh1729 will do.
This patch fixes the build and all tests pass. You want to merge it now?


Reply to this email directly or view it on GitHub
#11 (comment).

@achanda
Copy link
Contributor Author

achanda commented May 24, 2015

Thanks. The library looks great so far :)
Now that the build is fixed again, you should bump the version and push a new version to crates.io.

@shailesh1729
Copy link
Contributor

Done. The new version is up on crates.io.

On Sun, May 24, 2015 at 10:05 AM, Abhishek Chanda notifications@github.com
wrote:

Thanks. The library looks great so far :)
Now that the build is fixed again, you should bump the version and push a
new version to crates.io.


Reply to this email directly or view it on GitHub
#11 (comment).

@shailesh1729
Copy link
Contributor

For some unknown reason, the documentation on http://www.rust-ci.org/ never
gets updated. I tried many things but it's probably some bug in the
integration between travis build system and the rust-ci.org integration.
If you can identify any issue with the way my .travis.yml file is written,
do let me know. crates.io points to the same documentation link and it is
old!

On Sun, May 24, 2015 at 6:46 PM, Shailesh Kumar shailesh@indigits.com
wrote:

Done. The new version is up on crates.io.

On Sun, May 24, 2015 at 10:05 AM, Abhishek Chanda <
notifications@github.com> wrote:

Thanks. The library looks great so far :)
Now that the build is fixed again, you should bump the version and push a
new version to crates.io.


Reply to this email directly or view it on GitHub
#11 (comment).

@achanda
Copy link
Contributor Author

achanda commented May 25, 2015

@shailesh1729 I did not see anything that I thought was wrong. Might just be a bug, as you said. I did notice that a lot of people publish docs on their own websites or github pages. You can do that maybe?

@shailesh1729
Copy link
Contributor

That is already in place (through the separate gh-pages branch concept).
But it's not really automated, in the sense that it doesn't get updated
with every Travis successful build. And I am lazy to regularly update it :)
Will see what best can be done. Thanks.

On Mon, May 25, 2015 at 10:25 AM, Abhishek Chanda notifications@github.com
wrote:

@shailesh1729 https://github.com/shailesh1729 I did not see anything
that I thought was wrong. Might just be a bug, as you said. I did notice
that a lot of people publish docs on their own websites or github pages.
You can do that maybe?


Reply to this email directly or view it on GitHub
#11 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants