Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAM admins should be able to suspend clients #705

Closed
maarten-litmaath opened this issue Jan 30, 2024 · 6 comments · Fixed by #747
Closed

IAM admins should be able to suspend clients #705

maarten-litmaath opened this issue Jan 30, 2024 · 6 comments · Fixed by #747
Assignees

Comments

@maarten-litmaath
Copy link

IAM admins should be able to suspend clients:

If nobody complains about a particular client being suspended, it probably can be manually deleted as part of a cleanup operation.

@garaimanoj
Copy link
Contributor

garaimanoj commented Mar 5, 2024

If a client is suspended then which operations, done by the client, do we need to stop?
For example,

  • New action token request
  • Invalid refresh token issued by the client

Is there anything else we need to take care of?

@federicaagostini
Copy link
Contributor

Our conclusion after last IAM community meeting was that:

  • in case of suspended client, new access tokens cannot be issued anymore
  • RT may be still valid, but one cannot use the RT flow to get tokens.

If there is a security leak, we think the client should be deleted (with the consequence of all AT/RT being deleted as well).
Likely, the reason for disabling a client could be a temporary misbehavior, and we can leave the RT valid for instance to not force a user to set up oidc-agent again once the client will be re-enabled -- also, we do not see the difference between removing and disabling a client, otherwise.

What do you @giacomini and @maarten-litmaath think about it?

@giacomini
Copy link
Contributor

Should we also record the date of the suspension and show it in the dashboard and/or make it available in a search?

@maarten-litmaath
Copy link
Author

It would be good to have the date shown indeed. What about who did it?

@federicaagostini
Copy link
Contributor

PR #747

@enricovianello
Copy link
Member

This is an example of the new Disable Client button inside Client Edit page:

Image

The confirmation dialog:

Image

How the client is shown into client list:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants