Skip to content

Commit

Permalink
Reset mExposureRetry otherwise it keeps increasing until overflow
Browse files Browse the repository at this point in the history
  • Loading branch information
knro committed Mar 29, 2021
1 parent cc7e455 commit 5576d84
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions indi-asi/asi_ccd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,8 @@ void ASICCD::workerExposure(const std::atomic_bool &isAboutToQuit, float duratio
}
while (status != ASI_EXP_SUCCESS);

// Reset exposure retry
mExposureRetry = 0;
PrimaryCCD.setExposureLeft(0.0);
if (PrimaryCCD.getExposureDuration() > 3)
LOG_INFO("Exposure done, downloading image...");
Expand Down Expand Up @@ -997,6 +999,7 @@ bool ASICCD::activateCooler(bool enable)

bool ASICCD::StartExposure(float duration)
{
mExposureRetry = 0;
mWorker.start(std::bind(&ASICCD::workerExposure, this, std::placeholders::_1, duration));
return true;
}
Expand Down

3 comments on commit 5576d84

@pawel-soja
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed my last asi commit.
Has this issue been reported with other issues somewhere?

@pawel-soja
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw
I wrote to ZWO about the problems.

image

"I'm doing differently. I am waiting for data(prepare bulk transfer), Trigger, Time Wait and Stop. In short, I always have a prepared bulk transfers. After this Fix, I will never lose the first frame from the camera."

I got a note from ZWO about the exposure.
"we know where is the problem and will fix next update of SDK"

@knro
Copy link
Collaborator Author

@knro knro commented on 5576d84 Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! There has been a few issues reported in the forum, and others directly. Including:

  • ASI_CAMERA_REMOVED issue which I experience occasionally after the hotplug PR.
  • Failed to expose, which might be somewhat related to the above fix as well, but let's see.

Please sign in to comment.