Build fails due to ShutterParkPolicySP not declared

[ee5cd7d5d]

Building from bb4b9db (current HEAD) results in an error.

To Reproduce:

1. git clone
2. follow instructions for building all 3rd party drivers

Current system:

• OS: Arch Linux arctic 5.9.8-arch1-1 INDIdriver for the new direct drive mounts 'AOK Skywalker' from AOKSwiss/Magnetdrives #1 SMP PREEMPT Tue, 10 Nov 2020 22:44:11 +0000 x86_64 GNU/Linux
• Version 3rd Party bb4b9db
• Indi: libindi-1.8.7-1

Build log:

[ 24%] Building CXX object indi-maxdomeii/CMakeFiles/indi_maxdomeii.dir/maxdomeii.cpp.o
In file included from /usr/include/bits/libc-header-start.h:33,
from /usr/include/stdio.h:27,
from /usr/local/include/libindi/indiapi.h:27,
from /usr/local/include/libindi/indibase.h:4,
from /usr/local/include/libindi/basedevice.h:21,
from /usr/local/include/libindi/defaultdevice.h:21,
from /usr/local/include/libindi/indidome.h:25,
from /home/pedro/Projects/OBS/indi-3rdparty/indi-maxdomeii/maxdomeii.h:25,
from /home/pedro/Projects/OBS/indi-3rdparty/indi-maxdomeii/maxdomeii.cpp:23:
/usr/include/features.h:397:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
397 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
| ^~~~~~~
Scanning dependencies of target indi_talon6
[ 24%] Linking CXX executable indi_sx_ccd
/home/pedro/Projects/OBS/indi-3rdparty/indi-nexdome/nex_dome.cpp: In member function ‘virtual IPState NexDome::Park()’:
/home/pedro/Projects/OBS/indi-3rdparty/indi-nexdome/nex_dome.cpp:712:46: error: ‘ShutterParkPolicySP’ was not declared in this scope; did you mean ‘ShutterFactorySP’?
712 | if (HasShutter() && IUFindOnSwitchIndex(&ShutterParkPolicySP) == SHUTTER_CLOSE_ON_PARK)
| ^~~~~~~~~~~~~~~~~~~
| ShutterFactorySP
/home/pedro/Projects/OBS/indi-3rdparty/indi-nexdome/nex_dome.cpp:712:70: error: ‘SHUTTER_CLOSE_ON_PARK’ was not declared in this scope
712 | if (HasShutter() && IUFindOnSwitchIndex(&ShutterParkPolicySP) == SHUTTER_CLOSE_ON_PARK)
| ^~~~~~~~~~~~~~~~~~~~~
/home/pedro/Projects/OBS/indi-3rdparty/indi-nexdome/nex_dome.cpp: In member function ‘virtual IPState NexDome::UnPark()’:
/home/pedro/Projects/OBS/indi-3rdparty/indi-nexdome/nex_dome.cpp:729:46: error: ‘ShutterParkPolicySP’ was not declared in this scope; did you mean ‘ShutterFactorySP’?
729 | if (HasShutter() && IUFindOnSwitchIndex(&ShutterParkPolicySP) == SHUTTER_OPEN_ON_UNPARK)
| ^~~~~~~~~~~~~~~~~~~
| ShutterFactorySP
/home/pedro/Projects/OBS/indi-3rdparty/indi-nexdome/nex_dome.cpp:729:70: error: ‘SHUTTER_OPEN_ON_UNPARK’ was not declared in this scope
729 | if (HasShutter() && IUFindOnSwitchIndex(&ShutterParkPolicySP) == SHUTTER_OPEN_ON_UNPARK)
| ^~~~~~~~~~~~~~~~~~~~~~
[ 25%] Building CXX object indi-talon6/CMakeFiles/indi_talon6.dir/talon6.cpp.o
In file included from /usr/include/bits/libc-header-start.h:33,
from /usr/include/stdio.h:27,
from /usr/local/include/libindi/indiapi.h:27,
from /usr/local/include/libindi/indibase.h:4,
from /usr/local/include/libindi/basedevice.h:21,
from /usr/local/include/libindi/defaultdevice.h:21,
from /usr/local/include/libindi/indidome.h:25,
from /home/pedro/Projects/OBS/indi-3rdparty/indi-talon6/talon6.h:22,
from /home/pedro/Projects/OBS/indi-3rdparty/indi-talon6/talon6.cpp:19:
/usr/include/features.h:397:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
397 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
| ^~~~~~~
[ 25%] Linking CXX executable indi_maxdomeii
[ 25%] Built target indi_sx_ccd
[ 25%] Built target indi_maxdomeii
/home/pedro/Projects/OBS/indi-3rdparty/indi-nexdome/nex_dome.cpp:743:1: warning: control reaches end of non-void function [-Wreturn-type]
743 | }
| ^
/home/pedro/Projects/OBS/indi-3rdparty/indi-talon6/talon6.cpp: In member function ‘char Talon6::ShiftChar(char)’:
/home/pedro/Projects/OBS/indi-3rdparty/indi-talon6/talon6.cpp:888:14: warning: converting to non-pointer type ‘int’ from NULL [-Wconversion-null]
888 | case NULL:
| ^~~~
make[2]: *** [indi-nexdome/CMakeFiles/indi_nexdome.dir/build.make:82: indi-nexdome/CMakeFiles/indi_nexdome.dir/nex_dome.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1368: indi-nexdome/CMakeFiles/indi_nexdome.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 25%] Linking CXX executable indi_talon6
Scanning dependencies of target indi_spectracyber
[ 25%] Built target indi_talon6
Scanning dependencies of target indi_shelyakspox_spectrograph
[ 25%] Building CXX object indi-spectracyber/CMakeFiles/indi_spectracyber.dir/spectracyber.cpp.o
In file included from /usr/include/bits/libc-header-start.h:33,
from /usr/include/stdio.h:27,
from /usr/local/include/libindi/indiapi.h:27,
from /usr/local/include/libindi/indibase.h:4,
from /usr/local/include/libindi/basedevice.h:21,
from /usr/local/include/libindi/defaultdevice.h:21,
from /home/pedro/Projects/OBS/indi-3rdparty/indi-spectracyber/spectracyber.h:29,
from /home/pedro/Projects/OBS/indi-3rdparty/indi-spectracyber/spectracyber.cpp:31:
/usr/include/features.h:397:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
397 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
| ^~~~~~~
[ 26%] Building CXX object indi-shelyak/CMakeFiles/indi_shelyakspox_spectrograph.dir/indi_shelyakspox_spectrograph.cpp.o
In file included from /usr/include/bits/libc-header-start.h:33,
from /usr/include/stdio.h:27,
from /home/pedro/Projects/OBS/indi-3rdparty/indi-shelyak/indi_shelyakspox_spectrograph.cpp:24:
/usr/include/features.h:397:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
397 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
| ^~~~~~~
/home/pedro/Projects/OBS/indi-3rdparty/indi-shelyak/indi_shelyakspox_spectrograph.cpp: In member function ‘virtual bool ShelyakSpox::Connect()’:
/home/pedro/Projects/OBS/indi-3rdparty/indi-shelyak/indi_shelyakspox_spectrograph.cpp:169:9: warning: unused variable ‘tty_rc’ [-Wunused-variable]
169 | int tty_rc = tty_nread_section(PortFD, line, 80, 0x0a, 3, &bytes_read);
| ^~~~~~
[ 27%] Linking CXX executable indi_spectracyber
/home/pedro/Projects/OBS/indi-3rdparty/indi-shelyak/indi_shelyakspox_spectrograph.cpp: In member function ‘bool ShelyakSpox::calibrationUnitCommand(char, char)’:
/home/pedro/Projects/OBS/indi-3rdparty/indi-shelyak/indi_shelyakspox_spectrograph.cpp:384:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
384 | }
| ^
/home/pedro/Projects/OBS/indi-3rdparty/indi-shelyak/indi_shelyakspox_spectrograph.cpp:387:9: note: here
387 | case 0x30 : { //SKY button
| ^~~~
[ 27%] Built target indi_spectracyber
[ 27%] Linking CXX executable indi_shelyakspox_spectrograph
[ 27%] Built target indi_shelyakspox_spectrograph
make: *** [Makefile:171: all] Error 2