INDIdriver for the new direct drive mounts 'AOK Skywalker' from AOKSwiss/Magnetdrives

[escribana]

Looking forward to receive your opinions.

[knro]

Thank you for the patch, this is great! A couple more requirements:

1. The debian file (just copy debian/indi-avalon and change)
2. Documentation: Template found here --> https://github.com/indilib/indi/blob/master/drivers/README.md

Include screenshot for each tab + zip the whole documentation and attach it.

[escribana]

On Wed, 18 Sep 2019 07:52:05 -0700 Jasem Mutlaq ***@***.***> wrote: knro commented on this pull request. > +LIST(APPEND CMAKE_MODULE_PATH > "${CMAKE_CURRENT_SOURCE_DIR}/cmake_modules/") +LIST(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/../cmake_modules/") +include(GNUInstallDirs) + +find_package(INDI COMPONENTS driver lx200 REQUIRED) +find_package(Nova REQUIRED) + +include_directories(${CMAKE_CURRENT_BINARY_DIR}) +include_directories(${CMAKE_CURRENT_SOURCE_DIR}) +include_directories(${INDI_INCLUDE_DIR}) +include_directories(${NOVA_INCLUDE_DIR}) + +include(CMakeCommon) + +set(HERKULES_VERSION_MAJOR 0) +set(HERKULES_VERSION_MINOR 5) Shouldn't minor be 1?

... this is my "private" version number. ;-}

[knro]

The version number is actually fine. I thought I deleted this comment after I saw the changelog so disregard it. But the debian+documentation are still required :-)

[knro]

Hello, is there any update on the debian+documentation?

[escribana]

On Sat, 05 Oct 2019 22:30:00 -0700 Jasem Mutlaq ***@***.***> wrote: Hello, is there any update on the debian+documentation?

Yes, there is! I've made several improvments and begun to write the documentation. But I was really tied up to my business for the last two weeks, so the documents are not yet finished. BTW, I'm in contact with the developers of the mount and they want to rename the driver to "DDM Skywalker". Following their statement, the driver I wrote will handle the whole product line of the "Skywalker"-mounts (e.g. Herkules V12/V24/V48 and Atlas V24). As soon as the documention is audited and the code is fully improved and tested, I will put the renamed project. Regards Antonio

[escribana]

The Debian files are uploaded (see 6243880) and the requested douments are attached to this message.
The driver itself was tested during various nights and seems to work quite well! So I hope tit will make the way into the repo.

indi-aok.zip

[knro]

Thanks, that's great! Will upload documentation soon!

[knro]

I had to make a few changes to fix a few security warnings. Please check now.

Documentation is uploaded to website and launchpad builds updated to include the driver starting with the first nightly tomorrow.

[escribana]

All is ok!

The only thing I always stumbled upon is the Park button: The default naming still seems unintellegible to me. But after all it's peanuts!

[knro]

We can apply your suggestion to the INDI::Telescope class but we need some feedback from other developers on this.