Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZWO flip param from float to select options #399

Closed
luzik opened this issue May 12, 2021 · 3 comments
Closed

ZWO flip param from float to select options #399

luzik opened this issue May 12, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@luzik
Copy link

luzik commented May 12, 2021

I believe that flip param in ZWO settings should be INT not float, or float with step 1.0 within range 0-4, or just select with
-do not flip
-flip horizontally
-flip vertically
-flip both
@luzik luzik added the bug Something isn't working label May 12, 2021
@knro
Copy link
Collaborator

knro commented May 12, 2021

Right, a switch would make more sense. Then the switch updates the control with the correct value accordingly.

@knro knro added the help wanted Extra attention is needed label Sep 28, 2021
@knro
Copy link
Collaborator

knro commented Sep 28, 2021

Any idea if you can submit a patch for this?

@knro knro added the good first issue Good for newcomers label Sep 28, 2021
k-ross added a commit to k-ross/indi-3rdparty that referenced this issue Feb 5, 2022
@k-ross
Fix indilib#399: ZWO flip param from float to select options
4ea0688
@k-ross
Copy link
Contributor

k-ross commented Feb 5, 2022

I decided to take a stab at fixing this. Pull request created. :)

@knro knro closed this as completed in e81228b Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k-ross @knro @luzik